Skip to content

Commit

Permalink
BUG_ON() Conversion in drivers/block/
Browse files Browse the repository at this point in the history
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
  • Loading branch information
Eric Sesterhenn authored and Adrian Bunk committed Mar 24, 2006
1 parent 817dd6e commit 089fe1b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions drivers/block/DAC960.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,7 @@ static void *slice_dma_loaf(struct dma_loaf *loaf, size_t len,
void *cpu_end = loaf->cpu_free + len;
void *cpu_addr = loaf->cpu_free;

if (cpu_end > loaf->cpu_base + loaf->length)
BUG();
BUG_ON(cpu_end > loaf->cpu_base + loaf->length);
*dma_handle = loaf->dma_free;
loaf->cpu_free = cpu_end;
loaf->dma_free += len;
Expand Down
3 changes: 1 addition & 2 deletions drivers/block/cciss.c
Original file line number Diff line number Diff line change
Expand Up @@ -2361,8 +2361,7 @@ static void do_cciss_request(request_queue_t *q)
if (!creq)
goto startio;

if (creq->nr_phys_segments > MAXSGENTRIES)
BUG();
BUG_ON(creq->nr_phys_segments > MAXSGENTRIES);

if (( c = cmd_alloc(h, 1)) == NULL)
goto full;
Expand Down
2 changes: 1 addition & 1 deletion drivers/block/cciss_scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1316,7 +1316,7 @@ cciss_scsi_queue_command (struct scsi_cmnd *cmd, void (* done)(struct scsi_cmnd

cp->Request.Timeout = 0;
memset(cp->Request.CDB, 0, sizeof(cp->Request.CDB));
if (cmd->cmd_len > sizeof(cp->Request.CDB)) BUG();
BUG_ON(cmd->cmd_len > sizeof(cp->Request.CDB));
cp->Request.CDBLen = cmd->cmd_len;
memcpy(cp->Request.CDB, cmd->cmnd, cmd->cmd_len);
cp->Request.Type.Type = TYPE_CMD;
Expand Down
3 changes: 1 addition & 2 deletions drivers/block/cpqarray.c
Original file line number Diff line number Diff line change
Expand Up @@ -906,8 +906,7 @@ static void do_ida_request(request_queue_t *q)
if (!creq)
goto startio;

if (creq->nr_phys_segments > SG_MAX)
BUG();
BUG_ON(creq->nr_phys_segments > SG_MAX);

if ((c = cmd_alloc(h,1)) == NULL)
goto startio;
Expand Down

0 comments on commit 089fe1b

Please sign in to comment.