Skip to content

Commit

Permalink
[SCSI] aacraid: error return checking
Browse files Browse the repository at this point in the history
This patch adds some additional error return checking and error return
value propagation during initialization. Also, the deprecation of
pci_module_init with pci_register_driver along with the change in return
values.

Signed-off-by: Mark Haverkamp <markh@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Mark Haverkamp authored and James Bottomley committed Sep 26, 2005
1 parent 131256c commit 08efb7b
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions drivers/scsi/aacraid/linit.c
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,8 @@ static int __devinit aac_probe_one(struct pci_dev *pdev,
unique_id++;
}

if (pci_enable_device(pdev))
error = pci_enable_device(pdev);
if (error)
goto out;

if (pci_set_dma_mask(pdev, 0xFFFFFFFFULL) ||
Expand Down Expand Up @@ -800,7 +801,9 @@ static int __devinit aac_probe_one(struct pci_dev *pdev,
goto out_free_fibs;

aac->maximum_num_channels = aac_drivers[index].channels;
aac_get_adapter_info(aac);
error = aac_get_adapter_info(aac);
if (error < 0)
goto out_deinit;

/*
* Lets override negotiations and drop the maximum SG limit to 34
Expand Down Expand Up @@ -928,8 +931,8 @@ static int __init aac_init(void)
printk(KERN_INFO "Adaptec %s driver (%s)\n",
AAC_DRIVERNAME, aac_driver_version);

error = pci_module_init(&aac_pci_driver);
if (error)
error = pci_register_driver(&aac_pci_driver);
if (error < 0)
return error;

aac_cfg_major = register_chrdev( 0, "aac", &aac_cfg_fops);
Expand Down

0 comments on commit 08efb7b

Please sign in to comment.