Skip to content

Commit

Permalink
bnx2x: correct usleep_range usage
Browse files Browse the repository at this point in the history
Change the incorrect usage of `usleep_range(1000, 1000)' into
`usleep_range(1000, 2000)'.

Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yuval Mintz authored and David S. Miller committed Jan 23, 2013
1 parent 924d75a commit 0926d49
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ static inline int bnx2x_clean_tx_queue(struct bnx2x *bp,
#endif
}
cnt--;
usleep_range(1000, 1000);
usleep_range(1000, 2000);
}

return 0;
Expand Down Expand Up @@ -1259,7 +1259,7 @@ static inline bool bnx2x_wait_sp_comp(struct bnx2x *bp, unsigned long mask)
}
netif_addr_unlock_bh(bp->dev);

usleep_range(1000, 1000);
usleep_range(1000, 2000);
}

smp_mb();
Expand Down
10 changes: 5 additions & 5 deletions drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -8654,7 +8654,7 @@ void bnx2x_chip_cleanup(struct bnx2x *bp, int unload_mode, bool keep_link)
}

/* Give HW time to discard old tx messages */
usleep_range(1000, 1000);
usleep_range(1000, 2000);

/* Clean all ETH MACs */
rc = bnx2x_del_all_macs(bp, &bp->sp_objs[0].mac_obj, BNX2X_ETH_MAC,
Expand Down Expand Up @@ -9078,7 +9078,7 @@ static int bnx2x_er_poll_igu_vq(struct bnx2x *bp)
if (pend_bits == 0)
break;

usleep_range(1000, 1000);
usleep_range(1000, 2000);
} while (cnt-- > 0);

if (cnt <= 0) {
Expand Down Expand Up @@ -9113,7 +9113,7 @@ static int bnx2x_process_kill(struct bnx2x *bp, bool global)
(pgl_exp_rom2 == 0xffffffff) &&
(!CHIP_IS_E3(bp) || (tags_63_32 == 0xffffffff)))
break;
usleep_range(1000, 1000);
usleep_range(1000, 2000);
} while (cnt-- > 0);

if (cnt <= 0) {
Expand Down Expand Up @@ -9146,7 +9146,7 @@ static int bnx2x_process_kill(struct bnx2x *bp, bool global)
/* Wait for 1ms to empty GLUE and PCI-E core queues,
* PSWHST, GRC and PSWRD Tetris buffer.
*/
usleep_range(1000, 1000);
usleep_range(1000, 2000);

/* Prepare to chip reset: */
/* MCP */
Expand Down Expand Up @@ -10917,7 +10917,7 @@ static int bnx2x_get_hwinfo(struct bnx2x *bp)

while (tout && REG_RD(bp, IGU_REG_RESET_MEMORIES)) {
tout--;
usleep_range(1000, 1000);
usleep_range(1000, 2000);
}

if (REG_RD(bp, IGU_REG_RESET_MEMORIES)) {
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ static inline int bnx2x_state_wait(struct bnx2x *bp, int state,
return 0;
}

usleep_range(1000, 1000);
usleep_range(1000, 2000);

if (bp->panic)
return -EIO;
Expand Down Expand Up @@ -1407,7 +1407,7 @@ static int bnx2x_wait_vlan_mac(struct bnx2x *bp,

/* Wait until there are no pending commands */
if (!bnx2x_exe_queue_empty(exeq))
usleep_range(1000, 1000);
usleep_range(1000, 2000);
else
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ static int bnx2x_stats_comp(struct bnx2x *bp)
break;
}
cnt--;
usleep_range(1000, 1000);
usleep_range(1000, 2000);
}
return 1;
}
Expand Down

0 comments on commit 0926d49

Please sign in to comment.