Skip to content

Commit

Permalink
[PATCH] firmware/dcdbas: fix bug in error cleanup
Browse files Browse the repository at this point in the history
The error path path mistakenly called sysfs_create_group() rather than
sysfs_remove_group().  They take the same arguments, so it's easy to
cut-n-paste such a bug.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jeff Garzik authored and Linus Torvalds committed Oct 10, 2006
1 parent 15e541f commit 0968cf5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/firmware/dcdbas.c
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct platform_device *dev)
while (--i >= 0)
sysfs_remove_bin_file(&dev->dev.kobj,
dcdbas_bin_attrs[i]);
sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group);
sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group);
return error;
}
}
Expand Down

0 comments on commit 0968cf5

Please sign in to comment.