Skip to content

Commit

Permalink
ehea: Fix kernel deadlock in DLPAR-mem processing
Browse files Browse the repository at this point in the history
Port reset operations and memory add/remove operations need to
be serialized to avoid a kernel deadlock. The deadlock is caused
by calling the napi_disable() function twice.
Therefore we have to employ the dlpar_mem_lock in the ehea_reset_port
function as well

Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jan-Bernd Themann authored and David S. Miller committed Jun 17, 2010
1 parent a91fb14 commit 099473c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/net/ehea/ehea.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#include <asm/io.h>

#define DRV_NAME "ehea"
#define DRV_VERSION "EHEA_0103"
#define DRV_VERSION "EHEA_0105"

/* eHEA capability flags */
#define DLPAR_PORT_ADD_REM 1
Expand Down
8 changes: 3 additions & 5 deletions drivers/net/ehea/ehea_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2860,6 +2860,7 @@ static void ehea_reset_port(struct work_struct *work)
container_of(work, struct ehea_port, reset_task);
struct net_device *dev = port->netdev;

mutex_lock(&dlpar_mem_lock);
port->resets++;
mutex_lock(&port->port_lock);
netif_stop_queue(dev);
Expand All @@ -2882,6 +2883,7 @@ static void ehea_reset_port(struct work_struct *work)
netif_wake_queue(dev);
out:
mutex_unlock(&port->port_lock);
mutex_unlock(&dlpar_mem_lock);
}

static void ehea_rereg_mrs(struct work_struct *work)
Expand Down Expand Up @@ -3543,10 +3545,7 @@ static int ehea_mem_notifier(struct notifier_block *nb,
int ret = NOTIFY_BAD;
struct memory_notify *arg = data;

if (!mutex_trylock(&dlpar_mem_lock)) {
ehea_info("ehea_mem_notifier must not be called parallelized");
goto out;
}
mutex_lock(&dlpar_mem_lock);

switch (action) {
case MEM_CANCEL_OFFLINE:
Expand Down Expand Up @@ -3575,7 +3574,6 @@ static int ehea_mem_notifier(struct notifier_block *nb,

out_unlock:
mutex_unlock(&dlpar_mem_lock);
out:
return ret;
}

Expand Down

0 comments on commit 099473c

Please sign in to comment.