Skip to content

Commit

Permalink
b43: PHY: allow init optimizations by tracking PHY state
Browse files Browse the repository at this point in the history
PHY has to be often re-initialized (e.g. during band switching after PHY
reset), however some operations have to be performed only once (only
power reset affects them).

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Rafał Miłecki authored and John W. Linville committed May 29, 2014
1 parent cf42c4e commit 09951ad
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/wireless/b43/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -5164,6 +5164,7 @@ static void b43_supported_bands(struct b43_wldev *dev, bool *have_2ghz_phy,
static int b43_wireless_core_attach(struct b43_wldev *dev)
{
struct b43_wl *wl = dev->wl;
struct b43_phy *phy = &dev->phy;
int err;
u32 tmp;
bool have_2ghz_phy = false, have_5ghz_phy = false;
Expand All @@ -5181,6 +5182,8 @@ static int b43_wireless_core_attach(struct b43_wldev *dev)
goto out;
}

phy->do_full_init = true;

/* Try to guess supported bands for the first init needs */
switch (dev->dev->bus_type) {
#ifdef CONFIG_B43_BCMA
Expand Down
5 changes: 5 additions & 0 deletions drivers/net/wireless/b43/phy_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,14 @@ int b43_phy_init(struct b43_wldev *dev)

phy->ops->switch_analog(dev, true);
b43_software_rfkill(dev, false);

err = ops->init(dev);
if (err) {
b43err(dev->wl, "PHY init failed\n");
goto err_block_rf;
}
phy->do_full_init = false;

/* Make sure to switch hardware and firmware (SHM) to
* the default channel. */
err = b43_switch_channel(dev, ops->get_default_chan(dev));
Expand All @@ -114,6 +117,7 @@ int b43_phy_init(struct b43_wldev *dev)
return 0;

err_phy_exit:
phy->do_full_init = true;
if (ops->exit)
ops->exit(dev);
err_block_rf:
Expand All @@ -127,6 +131,7 @@ void b43_phy_exit(struct b43_wldev *dev)
const struct b43_phy_operations *ops = dev->phy.ops;

b43_software_rfkill(dev, true);
dev->phy.do_full_init = true;
if (ops->exit)
ops->exit(dev);
}
Expand Down
3 changes: 3 additions & 0 deletions drivers/net/wireless/b43/phy_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,9 @@ struct b43_phy {
/* Is GMODE (2 GHz mode) bit enabled? */
bool gmode;

/* After power reset full init has to be performed */
bool do_full_init;

/* Analog Type */
u8 analog;
/* B43_PHYTYPE_ */
Expand Down

0 comments on commit 09951ad

Please sign in to comment.