Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 30785
b: refs/heads/master
c: 8bcf613
h: refs/heads/master
i:
  30783: 3e3c924
v: v3
  • Loading branch information
Jim Cromie authored and Linus Torvalds committed Jun 28, 2006
1 parent 950b79a commit 09a0729
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 6cad56fd884b7eb85ae193c94b688fe76680fcbf
refs/heads/master: 8bcf6135c3e8cdfab375f4041a48721483519eee
8 changes: 4 additions & 4 deletions trunk/arch/i386/kernel/scx200.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include <linux/errno.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/mutex.h>
#include <linux/pci.h>

#include <linux/scx200.h>
Expand Down Expand Up @@ -45,7 +46,7 @@ static struct pci_driver scx200_pci_driver = {
.probe = scx200_probe,
};

static DEFINE_SPINLOCK(scx200_gpio_config_lock);
static DEFINE_MUTEX(scx200_gpio_config_lock);

static void __devinit scx200_init_shadow(void)
{
Expand Down Expand Up @@ -95,17 +96,16 @@ static int __devinit scx200_probe(struct pci_dev *pdev, const struct pci_device_
u32 scx200_gpio_configure(unsigned index, u32 mask, u32 bits)
{
u32 config, new_config;
unsigned long flags;

spin_lock_irqsave(&scx200_gpio_config_lock, flags);
mutex_lock(&scx200_gpio_config_lock);

outl(index, scx200_gpio_base + 0x20);
config = inl(scx200_gpio_base + 0x24);

new_config = (config & mask) | bits;
outl(new_config, scx200_gpio_base + 0x24);

spin_unlock_irqrestore(&scx200_gpio_config_lock, flags);
mutex_unlock(&scx200_gpio_config_lock);

return config;
}
Expand Down
8 changes: 4 additions & 4 deletions trunk/drivers/char/pc8736x_gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/ioport.h>
#include <linux/mutex.h>
#include <linux/nsc_gpio.h>
#include <linux/platform_device.h>
#include <asm/uaccess.h>
Expand All @@ -31,7 +32,7 @@ static int major; /* default to dynamic major */
module_param(major, int, 0);
MODULE_PARM_DESC(major, "Major device number");

static DEFINE_SPINLOCK(pc8736x_gpio_config_lock);
static DEFINE_MUTEX(pc8736x_gpio_config_lock);
static unsigned pc8736x_gpio_base;
static u8 pc8736x_gpio_shadow[4];

Expand Down Expand Up @@ -119,9 +120,8 @@ static inline u32 pc8736x_gpio_configure_fn(unsigned index, u32 mask, u32 bits,
u32 func_slct)
{
u32 config, new_config;
unsigned long flags;

spin_lock_irqsave(&pc8736x_gpio_config_lock, flags);
mutex_lock(&pc8736x_gpio_config_lock);

device_select(SIO_GPIO_UNIT);
select_pin(index);
Expand All @@ -133,7 +133,7 @@ static inline u32 pc8736x_gpio_configure_fn(unsigned index, u32 mask, u32 bits,
new_config = (config & mask) | bits;
superio_outb(func_slct, new_config);

spin_unlock_irqrestore(&pc8736x_gpio_config_lock, flags);
mutex_unlock(&pc8736x_gpio_config_lock);

return config;
}
Expand Down

0 comments on commit 09a0729

Please sign in to comment.