Skip to content

Commit

Permalink
mac80211: (really) fix rates setup on IBSS merge
Browse files Browse the repository at this point in the history
when an IBSS merge happened, the supported rates for the newly added station
were left empty, causing the rate control module to be initialized with only
the basic rates.

the section of the ibss code which deals with updating supported rates for
an already existing station failed to inform the rate control module about the
new rates. as both minstrel and pid don't have an update function i just use
the init function.

also remove unnecessary (unsigned long long) casts and edit debug message.

Signed-off-by: Bruno Randolf <br1@einfach.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Bruno Randolf authored and John W. Linville committed Mar 16, 2010
1 parent 819386d commit 09a08cf
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions net/mac80211/ibss.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,17 +264,16 @@ static void ieee80211_rx_bss_info(struct ieee80211_sub_if_data *sdata,
sta->sta.supp_rates[band] = supp_rates |
ieee80211_mandatory_rates(local, band);

if (sta->sta.supp_rates[band] != prev_rates) {
#ifdef CONFIG_MAC80211_IBSS_DEBUG
if (sta->sta.supp_rates[band] != prev_rates)
printk(KERN_DEBUG "%s: updated supp_rates set "
"for %pM based on beacon info (0x%llx | "
"0x%llx -> 0x%llx)\n",
sdata->name,
sta->sta.addr,
(unsigned long long) prev_rates,
(unsigned long long) supp_rates,
(unsigned long long) sta->sta.supp_rates[band]);
"for %pM based on beacon/probe_response "
"(0x%x -> 0x%x)\n",
sdata->name, sta->sta.addr,
prev_rates, sta->sta.supp_rates[band]);
#endif
rate_control_rate_init(sta);
}
rcu_read_unlock();
} else {
rcu_read_unlock();
Expand Down Expand Up @@ -370,6 +369,7 @@ static void ieee80211_rx_bss_info(struct ieee80211_sub_if_data *sdata,
sdata->name, mgmt->bssid);
#endif
ieee80211_sta_join_ibss(sdata, bss);
supp_rates = ieee80211_sta_get_rates(local, elems, band);
ieee80211_ibss_add_sta(sdata, mgmt->bssid, mgmt->sa,
supp_rates, GFP_KERNEL);
}
Expand Down

0 comments on commit 09a08cf

Please sign in to comment.