Skip to content

Commit

Permalink
vhost: don't open-code sockfd_put()
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Apr 2, 2014
1 parent 964ea96 commit 09aaacf
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions drivers/vhost/net.c
Original file line number Diff line number Diff line change
Expand Up @@ -818,9 +818,9 @@ static int vhost_net_release(struct inode *inode, struct file *f)
vhost_dev_cleanup(&n->dev, false);
vhost_net_vq_reset(n);
if (tx_sock)
fput(tx_sock->file);
sockfd_put(tx_sock);
if (rx_sock)
fput(rx_sock->file);
sockfd_put(rx_sock);
/* Make sure no callbacks are outstanding */
synchronize_rcu_bh();
/* We do an extra flush before freeing memory,
Expand Down Expand Up @@ -860,7 +860,7 @@ static struct socket *get_raw_socket(int fd)
}
return sock;
err:
fput(sock->file);
sockfd_put(sock);
return ERR_PTR(r);
}

Expand Down Expand Up @@ -966,7 +966,7 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd)

if (oldsock) {
vhost_net_flush_vq(n, index);
fput(oldsock->file);
sockfd_put(oldsock);
}

mutex_unlock(&n->dev.mutex);
Expand All @@ -978,7 +978,7 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd)
if (ubufs)
vhost_net_ubuf_put_wait_and_free(ubufs);
err_ubufs:
fput(sock->file);
sockfd_put(sock);
err_vq:
mutex_unlock(&vq->mutex);
err:
Expand Down Expand Up @@ -1009,9 +1009,9 @@ static long vhost_net_reset_owner(struct vhost_net *n)
done:
mutex_unlock(&n->dev.mutex);
if (tx_sock)
fput(tx_sock->file);
sockfd_put(tx_sock);
if (rx_sock)
fput(rx_sock->file);
sockfd_put(rx_sock);
return err;
}

Expand Down

0 comments on commit 09aaacf

Please sign in to comment.