Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 184951
b: refs/heads/master
c: d451b8d
h: refs/heads/master
i:
  184949: c8873f7
  184947: 798b07d
  184943: 20f0af6
v: v3
  • Loading branch information
Alexander Chiang authored and Roland Dreier committed Feb 24, 2010
1 parent 9b2c5dc commit 09d1077
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 6aa2a86ec430fb1ae739bd065d7ea6596997a2cf
refs/heads/master: d451b8df9f7e572ea77f976745f424dd1dae8aeb
15 changes: 9 additions & 6 deletions trunk/drivers/infiniband/core/user_mad.c
Original file line number Diff line number Diff line change
Expand Up @@ -974,13 +974,16 @@ static CLASS_ATTR(abi_version, S_IRUGO, show_abi_version, NULL);
static int ib_umad_init_port(struct ib_device *device, int port_num,
struct ib_umad_port *port)
{
int devnum;

spin_lock(&port_lock);
port->dev_num = find_first_zero_bit(dev_map, IB_UMAD_MAX_PORTS);
if (port->dev_num >= IB_UMAD_MAX_PORTS) {
devnum = find_first_zero_bit(dev_map, IB_UMAD_MAX_PORTS);
if (devnum >= IB_UMAD_MAX_PORTS) {
spin_unlock(&port_lock);
return -1;
}
set_bit(port->dev_num, dev_map);
port->dev_num = devnum;
set_bit(devnum, dev_map);
spin_unlock(&port_lock);

port->ib_dev = device;
Expand All @@ -992,7 +995,7 @@ static int ib_umad_init_port(struct ib_device *device, int port_num,
cdev_init(&port->cdev, &umad_fops);
port->cdev.owner = THIS_MODULE;
kobject_set_name(&port->cdev.kobj, "umad%d", port->dev_num);
if (cdev_add(&port->cdev, base_dev + port->dev_num, 1))
if (cdev_add(&port->cdev, base_dev + devnum, 1))
goto err_cdev;

port->dev = device_create(umad_class, device->dma_device,
Expand All @@ -1009,7 +1012,7 @@ static int ib_umad_init_port(struct ib_device *device, int port_num,
cdev_init(&port->sm_cdev, &umad_sm_fops);
port->sm_cdev.owner = THIS_MODULE;
kobject_set_name(&port->sm_cdev.kobj, "issm%d", port->dev_num);
if (cdev_add(&port->sm_cdev, base_dev + port->dev_num + IB_UMAD_MAX_PORTS, 1))
if (cdev_add(&port->sm_cdev, base_dev + devnum + IB_UMAD_MAX_PORTS, 1))
goto err_sm_cdev;

port->sm_dev = device_create(umad_class, device->dma_device,
Expand All @@ -1036,7 +1039,7 @@ static int ib_umad_init_port(struct ib_device *device, int port_num,

err_cdev:
cdev_del(&port->cdev);
clear_bit(port->dev_num, dev_map);
clear_bit(devnum, dev_map);

return -1;
}
Expand Down

0 comments on commit 09d1077

Please sign in to comment.