Skip to content

Commit

Permalink
ASoC: omap-mcbsp: Remove unused FRAME dma_op_mode
Browse files Browse the repository at this point in the history
The frame dma_op_mode has never been used, and it is just creating
confusion for users/developers.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Liam Girdwood <lrg@ti.com>
  • Loading branch information
Peter Ujfalusi authored and Liam Girdwood committed May 22, 2012
1 parent 778a17c commit 09fa37a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion sound/soc/omap/mcbsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ THRESHOLD_PROP_BUILDER(max_tx_thres);
THRESHOLD_PROP_BUILDER(max_rx_thres);

static const char *dma_op_modes[] = {
"element", "threshold", "frame",
"element", "threshold",
};

static ssize_t dma_op_mode_show(struct device *dev,
Expand Down
1 change: 0 additions & 1 deletion sound/soc/omap/mcbsp.h
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ enum {
/********************** McBSP DMA operating modes **************************/
#define MCBSP_DMA_MODE_ELEMENT 0
#define MCBSP_DMA_MODE_THRESHOLD 1
#define MCBSP_DMA_MODE_FRAME 2

/********************** McBSP WAKEUPEN bit definitions *********************/
#define RSYNCERREN BIT(0)
Expand Down
1 change: 0 additions & 1 deletion sound/soc/omap/omap-mcbsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ static int omap_mcbsp_dai_hw_params(struct snd_pcm_substream *substream,
}
if (mcbsp->pdata->buffer_size) {
dma_data->set_threshold = omap_mcbsp_set_threshold;
/* TODO: Currently, MODE_ELEMENT == MODE_FRAME */
if (mcbsp->dma_op_mode == MCBSP_DMA_MODE_THRESHOLD) {
int period_words, max_thrsh;

Expand Down

0 comments on commit 09fa37a

Please sign in to comment.