Skip to content

Commit

Permalink
[SCSI] sd: fix refcounting regression in suspend/resume routines
Browse files Browse the repository at this point in the history
This patch (as909) fixes a couple of refcounting errors in the sd
driver's suspend and resume methods.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Alan Stern authored and James Bottomley committed May 22, 2007
1 parent cab537d commit 09ff92f
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions drivers/scsi/sd.c
Original file line number Diff line number Diff line change
Expand Up @@ -1789,7 +1789,7 @@ static void sd_shutdown(struct device *dev)
static int sd_suspend(struct device *dev, pm_message_t mesg)
{
struct scsi_disk *sdkp = scsi_disk_get_from_dev(dev);
int ret;
int ret = 0;

if (!sdkp)
return 0; /* this can happen */
Expand All @@ -1798,30 +1798,34 @@ static int sd_suspend(struct device *dev, pm_message_t mesg)
sd_printk(KERN_NOTICE, sdkp, "Synchronizing SCSI cache\n");
ret = sd_sync_cache(sdkp);
if (ret)
return ret;
goto done;
}

if (mesg.event == PM_EVENT_SUSPEND &&
sdkp->device->manage_start_stop) {
sd_printk(KERN_NOTICE, sdkp, "Stopping disk\n");
ret = sd_start_stop_device(sdkp, 0);
if (ret)
return ret;
}

return 0;
done:
scsi_disk_put(sdkp);
return ret;
}

static int sd_resume(struct device *dev)
{
struct scsi_disk *sdkp = scsi_disk_get_from_dev(dev);
int ret = 0;

if (!sdkp->device->manage_start_stop)
return 0;
goto done;

sd_printk(KERN_NOTICE, sdkp, "Starting disk\n");
ret = sd_start_stop_device(sdkp, 1);

return sd_start_stop_device(sdkp, 1);
done:
scsi_disk_put(sdkp);
return ret;
}

/**
Expand Down

0 comments on commit 09ff92f

Please sign in to comment.