Skip to content

Commit

Permalink
[POWERPC] Removed remnants of bus_offset
Browse files Browse the repository at this point in the history
Removed the remants of bus_offset and use self_busno in the mv64x60 case
and use pci_assign_all_buses on 83xx/85xx.

83xx/85xx have multiple PHBs and the firmwares on these devices tend not
to handle topologies with P2P bridges well so we let Linux just reassign
the bus numbers to match.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
  • Loading branch information
Kumar Gala committed Jun 29, 2007
1 parent 5ab65ec commit 0a3786c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/83xx/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ int __init mpc83xx_add_bridge(struct device_node *dev)
" bus 0\n", dev->full_name);
}

pci_assign_all_buses = 1;
hose = pcibios_alloc_controller();
if (!hose)
return -ENOMEM;
Expand All @@ -80,7 +81,6 @@ int __init mpc83xx_add_bridge(struct device_node *dev)
if ((rsrc.start & 0xfffff) == 0x8600) {
setup_indirect_pci(hose, immr + 0x8380, immr + 0x8384);
primary = 0;
hose->bus_offset = hose->first_busno;
}

printk(KERN_INFO "Found MPC83xx PCI host bridge at 0x%016llx. "
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/85xx/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ int __init mpc85xx_add_bridge(struct device_node *dev)
" bus 0\n", dev->full_name);
}

pci_assign_all_buses = 1;
hose = pcibios_alloc_controller();
if (!hose)
return -ENOMEM;
Expand All @@ -71,7 +72,6 @@ int __init mpc85xx_add_bridge(struct device_node *dev)
if ((rsrc.start & 0xfffff) == 0x9000) {
setup_indirect_pci(hose, immr + 0x9000, immr + 0x9004);
primary = 0;
hose->bus_offset = hose->first_busno;
}

printk(KERN_INFO "Found MPC85xx PCI host bridge at 0x%016llx. "
Expand Down
4 changes: 2 additions & 2 deletions arch/powerpc/sysdev/indirect_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ indirect_read_config(struct pci_bus *bus, unsigned int devfn, int offset,
cfg_type = 1;

bus_no = (bus->number == hose->first_busno) ?
hose->self_busno : bus->number - hose->bus_offset;
hose->self_busno : bus->number;

PCI_CFG_OUT(hose->cfg_addr,
(0x80000000 | (bus_no << 16)
Expand Down Expand Up @@ -87,7 +87,7 @@ indirect_write_config(struct pci_bus *bus, unsigned int devfn, int offset,
cfg_type = 1;

bus_no = (bus->number == hose->first_busno) ?
hose->self_busno : bus->number - hose->bus_offset;
hose->self_busno : bus->number;

PCI_CFG_OUT(hose->cfg_addr,
(0x80000000 | (bus_no << 16)
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/sysdev/mv64x60_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ static int __init mv64x60_add_bridge(struct device_node *dev)
hose->last_busno = bus_range ? bus_range[1] : 0xff;

setup_indirect_pci(hose, rsrc.start, rsrc.start + 4);
hose->bus_offset = hose->first_busno;
hose->self_busno = hose->first_busno;

printk(KERN_INFO "Found MV64x60 PCI host bridge at 0x%016llx. "
"Firmware bus number: %d->%d\n",
Expand Down
1 change: 1 addition & 0 deletions include/asm-ppc/pci-bridge.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ struct pci_controller {
int first_busno;
int last_busno;
int self_busno;
/* bus_offset is only used by ARCH=ppc */
int bus_offset;

void __iomem *io_base_virt;
Expand Down

0 comments on commit 0a3786c

Please sign in to comment.