Skip to content

Commit

Permalink
HID: remove excessive _EMERG messages from hidraw
Browse files Browse the repository at this point in the history
We don't need to shout loudly when device gets disconnected
while hidraw node has been open, as this is properly handled
in disconnect() and protected by minors_lock already.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Kosina committed Mar 25, 2010
1 parent 2e57480 commit 0a50454
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/hid/hidraw.c
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@ static int hidraw_open(struct inode *inode, struct file *file)

mutex_lock(&minors_lock);
if (!hidraw_table[minor]) {
printk(KERN_EMERG "hidraw device with minor %d doesn't exist\n",
minor);
kfree(list);
err = -ENODEV;
goto out_unlock;
Expand Down Expand Up @@ -216,11 +214,8 @@ static int hidraw_release(struct inode * inode, struct file * file)
struct hidraw *dev;
struct hidraw_list *list = file->private_data;

if (!hidraw_table[minor]) {
printk(KERN_EMERG "hidraw device with minor %d doesn't exist\n",
minor);
if (!hidraw_table[minor])
return -ENODEV;
}

list_del(&list->node);
dev = hidraw_table[minor];
Expand Down

0 comments on commit 0a50454

Please sign in to comment.