Skip to content

Commit

Permalink
hwmon: (ltc4215) make sysfs file match the alarm cause
Browse files Browse the repository at this point in the history
The ltc4215 driver used the chip's "power good" status bit to provide
the power1_alarm file. This is wrong: the chip is really reporting the
status of one of the monitored voltages.

Change the sysfs file from power1_alarm to in2_min_alarm instead. This
matches the voltage that the chip is raising an alarm for.

Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
  • Loading branch information
Ira W. Snyder authored and Guenter Roeck committed Dec 13, 2010
1 parent 6313e3c commit 0a6bf65
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/hwmon/ltc4215.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ LTC4215_ALARM(curr1_max_alarm, (1 << 2), LTC4215_STATUS);

/* Power (virtual) */
LTC4215_POWER(power1_input);
LTC4215_ALARM(power1_alarm, (1 << 3), LTC4215_STATUS);

/* Input Voltage */
LTC4215_VOLTAGE(in1_input, LTC4215_ADIN);
Expand All @@ -214,6 +213,7 @@ LTC4215_ALARM(in1_min_alarm, (1 << 1), LTC4215_STATUS);

/* Output Voltage */
LTC4215_VOLTAGE(in2_input, LTC4215_SOURCE);
LTC4215_ALARM(in2_min_alarm, (1 << 3), LTC4215_STATUS);

/* Finally, construct an array of pointers to members of the above objects,
* as required for sysfs_create_group()
Expand All @@ -223,13 +223,13 @@ static struct attribute *ltc4215_attributes[] = {
&sensor_dev_attr_curr1_max_alarm.dev_attr.attr,

&sensor_dev_attr_power1_input.dev_attr.attr,
&sensor_dev_attr_power1_alarm.dev_attr.attr,

&sensor_dev_attr_in1_input.dev_attr.attr,
&sensor_dev_attr_in1_max_alarm.dev_attr.attr,
&sensor_dev_attr_in1_min_alarm.dev_attr.attr,

&sensor_dev_attr_in2_input.dev_attr.attr,
&sensor_dev_attr_in2_min_alarm.dev_attr.attr,

NULL,
};
Expand Down

0 comments on commit 0a6bf65

Please sign in to comment.