Skip to content

Commit

Permalink
backlight: jornada720: fix checkpatch error and warning
Browse files Browse the repository at this point in the history
This patch fixes the checkpatch error and warning as below:

  ERROR: return is not a function, parentheses are not required

Also, long comments are fixed for the preferred style.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jingoo Han authored and Linus Torvalds committed Dec 18, 2012
1 parent c0b6cc4 commit 0a75a56
Showing 1 changed file with 19 additions and 12 deletions.
31 changes: 19 additions & 12 deletions drivers/video/backlight/jornada720_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)

jornada_ssp_end();

return (BL_MAX_BRIGHT - ret);
return BL_MAX_BRIGHT - ret;
}

static int jornada_bl_update_status(struct backlight_device *bd)
Expand Down Expand Up @@ -77,18 +77,23 @@ static int jornada_bl_update_status(struct backlight_device *bd)
goto out;
}

/* at this point we expect that the mcu has accepted
our command and is waiting for our new value
please note that maximum brightness is 255,
but due to physical layout it is equal to 0, so we simply
invert the value (MAX VALUE - NEW VALUE). */
if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) != TXDUMMY) {
/*
* at this point we expect that the mcu has accepted
* our command and is waiting for our new value
* please note that maximum brightness is 255,
* but due to physical layout it is equal to 0, so we simply
* invert the value (MAX VALUE - NEW VALUE).
*/
if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness)
!= TXDUMMY) {
pr_err("set brightness failed\n");
ret = -ETIMEDOUT;
}

/* If infact we get an TXDUMMY as output we are happy and dont
make any further comments about it */
/*
* If infact we get an TXDUMMY as output we are happy and dont
* make any further comments about it
*/
out:
jornada_ssp_end();

Expand Down Expand Up @@ -121,9 +126,11 @@ static int jornada_bl_probe(struct platform_device *pdev)

bd->props.power = FB_BLANK_UNBLANK;
bd->props.brightness = BL_DEF_BRIGHT;
/* note. make sure max brightness is set otherwise
you will get seemingly non-related errors when
trying to change brightness */
/*
* note. make sure max brightness is set otherwise
* you will get seemingly non-related errors when
* trying to change brightness
*/
jornada_bl_update_status(bd);

platform_set_drvdata(pdev, bd);
Expand Down

0 comments on commit 0a75a56

Please sign in to comment.