Skip to content

Commit

Permalink
Blackfin: fix length checking in kgdb_ebin2mem
Browse files Browse the repository at this point in the history
The kgdb_ebin2mem() was decrementing the count variable to do parsing, but
then later still tries to use it based on its original meaning.  So leave
it untouched and use a different variable to walk the memory.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
  • Loading branch information
Roel Kluin authored and Mike Frysinger committed Jun 12, 2009
1 parent 11aca0e commit 0a99061
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions arch/blackfin/kernel/kgdb.c
Original file line number Diff line number Diff line change
Expand Up @@ -587,19 +587,18 @@ int kgdb_ebin2mem(char *buf, char *mem, int count)
unsigned short *mmr16;
unsigned long *mmr32;
int err;
int size = 0;
int size;
int cpu = raw_smp_processor_id();

tmp_old = tmp_new = buf;

while (count-- > 0) {
for (size = 0; size < count; ++size) {
if (*tmp_old == 0x7d)
*tmp_new = *(++tmp_old) ^ 0x20;
else
*tmp_new = *tmp_old;
tmp_new++;
tmp_old++;
size++;
}

err = validate_memory_access_address((unsigned long)mem, size);
Expand Down

0 comments on commit 0a99061

Please sign in to comment.