Skip to content

Commit

Permalink
dm: use bool bitfields in struct dm_target
Browse files Browse the repository at this point in the history
Use boolean bit fields for flags in struct dm_target.

Signed-off-by: Alasdair G Kergon <agk@redhat.com>
  • Loading branch information
Alasdair G Kergon committed Jul 27, 2012
1 parent 16ad3d1 commit 0ac5548
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion drivers/md/dm-crypt.c
Original file line number Diff line number Diff line change
Expand Up @@ -1694,7 +1694,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
}

ti->num_flush_requests = 1;
ti->discard_zeroes_data_unsupported = 1;
ti->discard_zeroes_data_unsupported = true;

return 0;

Expand Down
2 changes: 1 addition & 1 deletion drivers/md/dm-raid1.c
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ static int mirror_ctr(struct dm_target *ti, unsigned int argc, char **argv)

ti->num_flush_requests = 1;
ti->num_discard_requests = 1;
ti->discard_zeroes_data_unsupported = 1;
ti->discard_zeroes_data_unsupported = true;

ms->kmirrord_wq = alloc_workqueue("kmirrord",
WQ_NON_REENTRANT | WQ_MEM_RECLAIM, 0);
Expand Down
8 changes: 4 additions & 4 deletions drivers/md/dm-thin.c
Original file line number Diff line number Diff line change
Expand Up @@ -2053,7 +2053,7 @@ static int pool_ctr(struct dm_target *ti, unsigned argc, char **argv)
* stacking of discard limits (this keeps the pool and
* thin devices' discard limits consistent).
*/
ti->discards_supported = 1;
ti->discards_supported = true;
}
ti->private = pt;

Expand Down Expand Up @@ -2656,11 +2656,11 @@ static int thin_ctr(struct dm_target *ti, unsigned argc, char **argv)

/* In case the pool supports discards, pass them on. */
if (tc->pool->pf.discard_enabled) {
ti->discards_supported = 1;
ti->discards_supported = true;
ti->num_discard_requests = 1;
ti->discard_zeroes_data_unsupported = 1;
ti->discard_zeroes_data_unsupported = true;
/* Discard requests must be split on a block boundary */
ti->split_discard_requests = 1;
ti->split_discard_requests = true;
}

dm_put(pool_md);
Expand Down
6 changes: 3 additions & 3 deletions include/linux/device-mapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -221,18 +221,18 @@ struct dm_target {
* Set if this target needs to receive discards regardless of
* whether or not its underlying devices have support.
*/
unsigned discards_supported:1;
bool discards_supported:1;

/*
* Set if the target required discard request to be split
* on max_io_len boundary.
*/
unsigned split_discard_requests:1;
bool split_discard_requests:1;

/*
* Set if this target does not return zeroes on discarded blocks.
*/
unsigned discard_zeroes_data_unsupported:1;
bool discard_zeroes_data_unsupported:1;
};

/* Each target can link one of these into the table */
Expand Down

0 comments on commit 0ac5548

Please sign in to comment.