Skip to content

Commit

Permalink
staging: hv: remove ASSERT()s in Channel.c
Browse files Browse the repository at this point in the history
These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Bill Pemberton authored and Greg Kroah-Hartman committed May 11, 2010
1 parent 002b53e commit 0ace247
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions drivers/staging/hv/Channel.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
DPRINT_ENTER(VMBUS);

/* Aligned to page size */
ASSERT(!(SendRingBufferSize & (PAGE_SIZE - 1)));
ASSERT(!(RecvRingBufferSize & (PAGE_SIZE - 1)));
/* ASSERT(!(SendRingBufferSize & (PAGE_SIZE - 1))); */
/* ASSERT(!(RecvRingBufferSize & (PAGE_SIZE - 1))); */

NewChannel->OnChannelCallback = OnChannelCallback;
NewChannel->ChannelCallbackContext = Context;
Expand All @@ -195,7 +195,7 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
if (!out)
return -ENOMEM;

ASSERT(((unsigned long)out & (PAGE_SIZE-1)) == 0);
/* ASSERT(((unsigned long)out & (PAGE_SIZE-1)) == 0); */

in = (void *)((unsigned long)out + SendRingBufferSize);

Expand Down Expand Up @@ -373,7 +373,7 @@ static int VmbusChannelCreateGpadlHeader(void *Kbuffer, u32 Size,
int pfnSum, pfnCount, pfnLeft, pfnCurr, pfnSize;

/* ASSERT((kbuffer & (PAGE_SIZE-1)) == 0); */
ASSERT((Size & (PAGE_SIZE-1)) == 0);
/* ASSERT((Size & (PAGE_SIZE-1)) == 0); */

pageCount = Size >> PAGE_SHIFT;
pfn = virt_to_phys(Kbuffer) >> PAGE_SHIFT;
Expand Down Expand Up @@ -601,7 +601,7 @@ int VmbusChannelTeardownGpadl(struct vmbus_channel *Channel, u32 GpadlHandle)

DPRINT_ENTER(VMBUS);

ASSERT(GpadlHandle != 0);
/* ASSERT(GpadlHandle != 0); */

info = kmalloc(sizeof(*info) +
sizeof(struct vmbus_channel_gpadl_teardown), GFP_KERNEL);
Expand Down Expand Up @@ -746,7 +746,7 @@ int VmbusChannelSendPacket(struct vmbus_channel *Channel, const void *Buffer,

DumpVmbusChannel(Channel);

ASSERT((packetLenAligned - packetLen) < sizeof(u64));
/* ASSERT((packetLenAligned - packetLen) < sizeof(u64)); */

/* Setup the descriptor */
desc.Type = Type; /* VmbusPacketTypeDataInBand; */
Expand Down Expand Up @@ -808,7 +808,7 @@ int VmbusChannelSendPacketPageBuffer(struct vmbus_channel *Channel,
packetLen = descSize + BufferLen;
packetLenAligned = ALIGN_UP(packetLen, sizeof(u64));

ASSERT((packetLenAligned - packetLen) < sizeof(u64));
/* ASSERT((packetLenAligned - packetLen) < sizeof(u64)); */

/* Setup the descriptor */
desc.Type = VmbusPacketTypeDataUsingGpaDirect;
Expand Down Expand Up @@ -878,7 +878,7 @@ int VmbusChannelSendPacketMultiPageBuffer(struct vmbus_channel *Channel,
packetLen = descSize + BufferLen;
packetLenAligned = ALIGN_UP(packetLen, sizeof(u64));

ASSERT((packetLenAligned - packetLen) < sizeof(u64));
/* ASSERT((packetLenAligned - packetLen) < sizeof(u64)); */

/* Setup the descriptor */
desc.Type = VmbusPacketTypeDataUsingGpaDirect;
Expand Down Expand Up @@ -1056,7 +1056,7 @@ int VmbusChannelRecvPacketRaw(struct vmbus_channel *Channel, void *Buffer,
void VmbusChannelOnChannelEvent(struct vmbus_channel *Channel)
{
DumpVmbusChannel(Channel);
ASSERT(Channel->OnChannelCallback);
/* ASSERT(Channel->OnChannelCallback); */

Channel->OnChannelCallback(Channel->ChannelCallbackContext);

Expand Down

0 comments on commit 0ace247

Please sign in to comment.