Skip to content

Commit

Permalink
USB: serial: fix error message on close in generic driver
Browse files Browse the repository at this point in the history
Resubmitting read urb fails with -EPERM if completion handler runs while
urb is being killed on close. This should not be reported as an error.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Johan Hovold authored and Greg Kroah-Hartman committed Mar 19, 2010
1 parent 7152b59 commit 0ae1474
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/usb/serial/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -415,11 +415,13 @@ void usb_serial_generic_resubmit_read_urb(struct usb_serial_port *port,
((serial->type->read_bulk_callback) ?
serial->type->read_bulk_callback :
usb_serial_generic_read_bulk_callback), port);

result = usb_submit_urb(urb, mem_flags);
if (result)
if (result && result != -EPERM) {
dev_err(&port->dev,
"%s - failed resubmitting read urb, error %d\n",
__func__, result);
}
}
EXPORT_SYMBOL_GPL(usb_serial_generic_resubmit_read_urb);

Expand Down

0 comments on commit 0ae1474

Please sign in to comment.