Skip to content

Commit

Permalink
[media] fintek-cir: make suspend with active IR more reliable
Browse files Browse the repository at this point in the history
There was a missing lock in fintek_suspend. Without the lock, its
possible the system will be in the middle of receiving IR (draining the
RX buffer) when we try to disable CIR interrupts.

Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jarod Wilson authored and Mauro Carvalho Chehab committed Jun 11, 2011
1 parent 8de111e commit 0ae9025
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/media/rc/fintek-cir.c
Original file line number Diff line number Diff line change
Expand Up @@ -597,12 +597,17 @@ static void __devexit fintek_remove(struct pnp_dev *pdev)
static int fintek_suspend(struct pnp_dev *pdev, pm_message_t state)
{
struct fintek_dev *fintek = pnp_get_drvdata(pdev);
unsigned long flags;

fit_dbg("%s called", __func__);

spin_lock_irqsave(&fintek->fintek_lock, flags);

/* disable all CIR interrupts */
fintek_cir_reg_write(fintek, CIR_STATUS_IRQ_MASK, CIR_STATUS);

spin_unlock_irqrestore(&fintek->fintek_lock, flags);

fintek_config_mode_enable(fintek);

/* disable cir logical dev */
Expand Down

0 comments on commit 0ae9025

Please sign in to comment.