Skip to content

Commit

Permalink
iommu/omap: Remove unnecessary null pointer check
Browse files Browse the repository at this point in the history
The pointer obj is dereferenced in line 146 and 149 respectively, so it is not
necessary to check null again in line 149 and 175. And I have checked that all
the callers of these two functions guarantee the parameter obj passed is not
null.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Acked-by: Ohad Ben-Cohen <ohad@wizery.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
  • Loading branch information
Cong Ding authored and Joerg Roedel committed Jan 28, 2013
1 parent 949db15 commit 0af125c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/iommu/omap-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ static int iommu_enable(struct omap_iommu *obj)
struct platform_device *pdev = to_platform_device(obj->dev);
struct iommu_platform_data *pdata = pdev->dev.platform_data;

if (!obj || !pdata)
if (!pdata)
return -EINVAL;

if (!arch_iommu)
Expand All @@ -172,7 +172,7 @@ static void iommu_disable(struct omap_iommu *obj)
struct platform_device *pdev = to_platform_device(obj->dev);
struct iommu_platform_data *pdata = pdev->dev.platform_data;

if (!obj || !pdata)
if (!pdata)
return;

arch_iommu->disable(obj);
Expand Down

0 comments on commit 0af125c

Please sign in to comment.