Skip to content

Commit

Permalink
Staging: hv: mousevsc: Get rid of unnecessary DPRINT calls
Browse files Browse the repository at this point in the history
Get rid of unnecessary DPRINT calls.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Oct 4, 2011
1 parent da5969e commit 0b1f0da
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions drivers/staging/hv/hv_mouse.c
Original file line number Diff line number Diff line change
Expand Up @@ -665,10 +665,8 @@ static void reportdesc_callback(struct hv_device *dev, void *packet, u32 len)
hid_dev->ll_driver = &mousevsc_ll_driver;
hid_dev->driver = &mousevsc_hid_driver;

if (hid_parse_report(hid_dev, packet, len)) {
DPRINT_INFO(INPUTVSC_DRV, "Unable to call hd_parse_report");
if (hid_parse_report(hid_dev, packet, len))
return;
}

hid_dev->bus = BUS_VIRTUAL;
hid_dev->vendor = input_device->hid_dev_info.vendor;
Expand Down Expand Up @@ -797,19 +795,15 @@ static int mousevsc_probe(struct hv_device *dev,
/* Call to the vsc driver to add the device */
ret = mousevsc_on_device_add(dev, NULL);

if (ret != 0) {
DPRINT_ERR(INPUTVSC_DRV, "unable to add input vsc device");

if (ret != 0)
return -1;
}

return 0;
}

static int mousevsc_remove(struct hv_device *dev)
{
struct mousevsc_dev *input_dev = hv_get_drvdata(dev);
int ret;

if (input_dev->connected) {
hidinput_disconnect(input_dev->hid_device);
Expand All @@ -821,13 +815,7 @@ static int mousevsc_remove(struct hv_device *dev)
* Call to the vsc driver to let it know that the device
* is being removed
*/
ret = mousevsc_on_device_remove(dev);
if (ret != 0) {
DPRINT_ERR(INPUTVSC_DRV,
"unable to remove vsc device (ret %d)", ret);
}

return ret;
return mousevsc_on_device_remove(dev);
}

static const struct hv_vmbus_device_id id_table[] = {
Expand Down

0 comments on commit 0b1f0da

Please sign in to comment.