Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 350102
b: refs/heads/master
c: a932b73
h: refs/heads/master
v: v3
  • Loading branch information
Oleg Nesterov committed Feb 8, 2013
1 parent b9e5045 commit 0b3f045
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 30 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b64b007797c1e6d6b745c93c296ba1d5f4d72d86
refs/heads/master: a932b7381f81235530c3d0acbd3ba2c7537d78e5
35 changes: 6 additions & 29 deletions trunk/kernel/trace/trace_uprobe.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,11 @@
/*
* uprobe event core functions
*/
struct trace_uprobe;
struct uprobe_trace_consumer {
struct uprobe_consumer cons;
struct trace_uprobe *tu;
};

struct trace_uprobe {
struct list_head list;
struct ftrace_event_class class;
struct ftrace_event_call call;
struct uprobe_trace_consumer *consumer;
struct uprobe_consumer consumer;
struct inode *inode;
char *filename;
unsigned long offset;
Expand Down Expand Up @@ -92,6 +86,7 @@ alloc_trace_uprobe(const char *group, const char *event, int nargs)
goto error;

INIT_LIST_HEAD(&tu->list);
tu->consumer.handler = uprobe_dispatcher;
return tu;

error:
Expand Down Expand Up @@ -546,27 +541,15 @@ static inline bool is_trace_uprobe_enabled(struct trace_uprobe *tu)

static int probe_event_enable(struct trace_uprobe *tu, int flag)
{
struct uprobe_trace_consumer *utc;
int ret = 0;

if (is_trace_uprobe_enabled(tu))
return -EINTR;

utc = kzalloc(sizeof(struct uprobe_trace_consumer), GFP_KERNEL);
if (!utc)
return -EINTR;

utc->cons.handler = uprobe_dispatcher;
utc->tu = tu;
tu->consumer = utc;
tu->flags |= flag;

ret = uprobe_register(tu->inode, tu->offset, &utc->cons);
if (ret) {
tu->consumer = NULL;
ret = uprobe_register(tu->inode, tu->offset, &tu->consumer);
if (ret)
tu->flags &= ~flag;
kfree(utc);
}

return ret;
}
Expand All @@ -576,10 +559,8 @@ static void probe_event_disable(struct trace_uprobe *tu, int flag)
if (!is_trace_uprobe_enabled(tu))
return;

uprobe_unregister(tu->inode, tu->offset, &tu->consumer->cons);
uprobe_unregister(tu->inode, tu->offset, &tu->consumer);
tu->flags &= ~flag;
kfree(tu->consumer);
tu->consumer = NULL;
}

static int uprobe_event_define_fields(struct ftrace_event_call *event_call)
Expand Down Expand Up @@ -717,13 +698,9 @@ int trace_uprobe_register(struct ftrace_event_call *event, enum trace_reg type,

static int uprobe_dispatcher(struct uprobe_consumer *con, struct pt_regs *regs)
{
struct uprobe_trace_consumer *utc;
struct trace_uprobe *tu;

utc = container_of(con, struct uprobe_trace_consumer, cons);
tu = utc->tu;
if (!tu || tu->consumer != utc)
return 0;
tu = container_of(con, struct trace_uprobe, consumer);

if (tu->flags & TP_FLAG_TRACE)
uprobe_trace_func(tu, regs);
Expand Down

0 comments on commit 0b3f045

Please sign in to comment.