Skip to content

Commit

Permalink
HID: roccat: remove obsolete kone_abi_version sysfs attribute
Browse files Browse the repository at this point in the history
The newest version of the accompanying userland tools cuts backward
compatibility and uses libudev to find its devices superseding the
quirky kone_abi_version sysfs attribute. Therefore it should be removed.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Stefan Achatz authored and Jiri Kosina committed Jun 21, 2010
1 parent cab6b16 commit 0b3fa39
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 30 deletions.
12 changes: 0 additions & 12 deletions Documentation/ABI/testing/sysfs-driver-hid-roccat-kone
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@ Description: When read, this file returns the raw integer version number of the
left. E.g. a returned value of 138 means 1.38
This file is readonly.

What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/kone_abi_version
Date: May 2010
Contact: Stefan Achatz <erazor_de@users.sourceforge.net>
Description: When read, this file returns the abi version as an integer value.
This attribute is used by the userland tools to find the sysfs-
paths of installed kone-mice and determine the capabilites of
the driver. Versions of this driver for old kernels replace
usbhid instead of generic-usb. The way to scan for this file
has been chosen to provide a consistent way for all supported
kernel versions.
This file is readonly.

What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/profile[1-5]
Date: March 2010
Contact: Stefan Achatz <erazor_de@users.sourceforge.net>
Expand Down
16 changes: 0 additions & 16 deletions drivers/hid/hid-roccat-kone.c
Original file line number Diff line number Diff line change
Expand Up @@ -617,18 +617,6 @@ static ssize_t kone_sysfs_set_startup_profile(struct device *dev,
return size;
}

/*
* This file is used by userland software to find devices that are handled by
* this driver. This provides a consistent way for actual and older kernels
* where this driver replaced usbhid instead of generic-usb.
* Driver capabilities are determined by returned number.
*/
static ssize_t kone_sysfs_show_abi_version(struct device *dev,
struct device_attribute *attr, char *buf)
{
return snprintf(buf, PAGE_SIZE, ROCCAT_KONE_ABI_VERSION "\n");
}

/*
* Read actual dpi settings.
* Returns raw value for further processing. Refer to enum kone_polling_rates to
Expand Down Expand Up @@ -666,17 +654,13 @@ static DEVICE_ATTR(startup_profile, 0660,
kone_sysfs_show_startup_profile,
kone_sysfs_set_startup_profile);

static DEVICE_ATTR(kone_abi_version, 0440,
kone_sysfs_show_abi_version, NULL);

static struct attribute *kone_attributes[] = {
&dev_attr_actual_dpi.attr,
&dev_attr_actual_profile.attr,
&dev_attr_weight.attr,
&dev_attr_firmware_version.attr,
&dev_attr_tcu.attr,
&dev_attr_startup_profile.attr,
&dev_attr_kone_abi_version.attr,
NULL
};

Expand Down
2 changes: 0 additions & 2 deletions drivers/hid/hid-roccat-kone.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

#include <linux/types.h>

#define ROCCAT_KONE_ABI_VERSION "1"

#pragma pack(push)
#pragma pack(1)

Expand Down

0 comments on commit 0b3fa39

Please sign in to comment.