Skip to content

Commit

Permalink
Use lock_page_killable
Browse files Browse the repository at this point in the history
Replacing lock_page with lock_page_killable in do_generic_mapping_read()
allows us to kill `cat' of a file on an NFS-mounted filesystem

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
  • Loading branch information
Matthew Wilcox authored and Matthew Wilcox committed Dec 6, 2007
1 parent 2687a35 commit 0b94e97
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,8 @@ void do_generic_mapping_read(struct address_space *mapping,

page_not_up_to_date:
/* Get exclusive access to the page ... */
lock_page(page);
if (lock_page_killable(page))
goto readpage_eio;

/* Did it get truncated before we got the lock? */
if (!page->mapping) {
Expand Down Expand Up @@ -1010,7 +1011,8 @@ void do_generic_mapping_read(struct address_space *mapping,
}

if (!PageUptodate(page)) {
lock_page(page);
if (lock_page_killable(page))
goto readpage_eio;
if (!PageUptodate(page)) {
if (page->mapping == NULL) {
/*
Expand All @@ -1021,15 +1023,16 @@ void do_generic_mapping_read(struct address_space *mapping,
goto find_page;
}
unlock_page(page);
error = -EIO;
shrink_readahead_size_eio(filp, ra);
goto readpage_error;
goto readpage_eio;
}
unlock_page(page);
}

goto page_ok;

readpage_eio:
error = -EIO;
readpage_error:
/* UHHUH! A synchronous read error occurred. Report it */
desc->error = error;
Expand Down

0 comments on commit 0b94e97

Please sign in to comment.