Skip to content

Commit

Permalink
[media] em28xx: Fix height setting on non-progressive captures
Browse files Browse the repository at this point in the history
This was introduced on commit c2a6b54:
"em28xx: fix: don't do image interlacing on webcams"

The proposed patch by Ezequiel is wrong. The right fix here is to just
don't bother here if either the image is progressive or not.

Reported-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Aug 12, 2012
1 parent 229fd7d commit 0bc9c89
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/media/video/em28xx/em28xx-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -785,12 +785,8 @@ int em28xx_resolution_set(struct em28xx *dev)
else
dev->vbi_height = 18;

if (!dev->progressive)
height >>= norm_maxh(dev);

em28xx_set_outfmt(dev);


em28xx_accumulator_set(dev, 1, (width - 4) >> 2, 1, (height - 4) >> 2);

/* If we don't set the start position to 2 in VBI mode, we end up
Expand Down

0 comments on commit 0bc9c89

Please sign in to comment.