Skip to content

Commit

Permalink
firewire: don't panic on invalid AR request buffer
Browse files Browse the repository at this point in the history
BUG() at this place is wrong.  (Unless if the low level driver would
already do higher-level input validation of incoming request headers.)

Invalid incoming requests or bugs in the controller which corrupt the
AR-req buffer needlessly crashed the box because this is run in tasklet
context.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed Jun 18, 2008
1 parent 952f4a0 commit 0bf607c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/firewire/fw-transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,8 @@ allocate_request(struct fw_packet *p)
break;

default:
BUG();
fw_error("ERROR - corrupt request received - %08x %08x %08x\n",
p->header[0], p->header[1], p->header[2]);
return NULL;
}

Expand Down

0 comments on commit 0bf607c

Please sign in to comment.