Skip to content

Commit

Permalink
[PATCH] kill_pid_info: kill acquired_tasklist_lock
Browse files Browse the repository at this point in the history
Kill acquired_tasklist_lock, sig_needs_tasklist() is very cheap nowadays.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Feb 11, 2007
1 parent b963a84 commit 0c12b51
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1119,19 +1119,18 @@ kill_pg_info(int sig, struct siginfo *info, pid_t pgrp)
int kill_pid_info(int sig, struct siginfo *info, struct pid *pid)
{
int error;
int acquired_tasklist_lock = 0;
struct task_struct *p;

rcu_read_lock();
if (unlikely(sig_needs_tasklist(sig))) {
if (unlikely(sig_needs_tasklist(sig)))
read_lock(&tasklist_lock);
acquired_tasklist_lock = 1;
}

p = pid_task(pid, PIDTYPE_PID);
error = -ESRCH;
if (p)
error = group_send_sig_info(sig, info, p);
if (unlikely(acquired_tasklist_lock))

if (unlikely(sig_needs_tasklist(sig)))
read_unlock(&tasklist_lock);
rcu_read_unlock();
return error;
Expand Down

0 comments on commit 0c12b51

Please sign in to comment.