Skip to content

Commit

Permalink
gpio: rcar: NULL dereference on error in probe()
Browse files Browse the repository at this point in the history
It's not obvious from the label name but "err1" tries to release
"p->irq_domain" which leads to a NULL dereference.

Fixes: 119f5e4 ('gpio: Renesas R-Car GPIO driver V3')

Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Magnus Damm <damm@opensource.se>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Dan Carpenter authored and Linus Walleij committed Nov 25, 2013
1 parent bfea603 commit 0c8aab8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/gpio-rcar.c
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
if (!p->irq_domain) {
ret = -ENXIO;
dev_err(&pdev->dev, "cannot initialize irq domain\n");
goto err1;
goto err0;
}

if (devm_request_irq(&pdev->dev, irq->start,
Expand Down

0 comments on commit 0c8aab8

Please sign in to comment.