Skip to content

Commit

Permalink
drm/exynos: remove needless error handling to property.
Browse files Browse the repository at this point in the history
This patch removes property error handling. because property couldn't be NULL.

Signed-off-by: Eunchul Kim <chulspro.kim@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
  • Loading branch information
Eunchul Kim authored and Inki Dae committed Jan 4, 2013
1 parent 7259c3d commit 0ca824c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 29 deletions.
12 changes: 0 additions & 12 deletions drivers/gpu/drm/exynos/exynos_drm_fimc.c
Original file line number Diff line number Diff line change
Expand Up @@ -705,10 +705,6 @@ static int fimc_src_set_addr(struct device *dev,
}

property = &c_node->property;
if (!property) {
DRM_ERROR("failed to get property.\n");
return -EINVAL;
}

DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__,
property->prop_id, buf_id, buf_type);
Expand Down Expand Up @@ -1241,10 +1237,6 @@ static int fimc_dst_set_addr(struct device *dev,
}

property = &c_node->property;
if (!property) {
DRM_ERROR("failed to get property.\n");
return -EINVAL;
}

DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__,
property->prop_id, buf_id, buf_type);
Expand Down Expand Up @@ -1573,10 +1565,6 @@ static int fimc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd)
}

property = &c_node->property;
if (!property) {
DRM_ERROR("failed to get property.\n");
return -EINVAL;
}

fimc_handle_irq(ctx, true, false, true);

Expand Down
12 changes: 0 additions & 12 deletions drivers/gpu/drm/exynos/exynos_drm_gsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -720,10 +720,6 @@ static int gsc_src_set_addr(struct device *dev,
}

property = &c_node->property;
if (!property) {
DRM_ERROR("failed to get property.\n");
return -EFAULT;
}

DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__,
property->prop_id, buf_id, buf_type);
Expand Down Expand Up @@ -1180,10 +1176,6 @@ static int gsc_dst_set_addr(struct device *dev,
}

property = &c_node->property;
if (!property) {
DRM_ERROR("failed to get property.\n");
return -EFAULT;
}

DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__,
property->prop_id, buf_id, buf_type);
Expand Down Expand Up @@ -1565,10 +1557,6 @@ static int gsc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd)
}

property = &c_node->property;
if (!property) {
DRM_ERROR("failed to get property.\n");
return -EINVAL;
}

gsc_handle_irq(ctx, true, false, true);

Expand Down
5 changes: 0 additions & 5 deletions drivers/gpu/drm/exynos/exynos_drm_ipp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1487,11 +1487,6 @@ void ipp_sched_cmd(struct work_struct *work)
mutex_lock(&c_node->cmd_lock);

property = &c_node->property;
if (!property) {
DRM_ERROR("failed to get property:prop_id[%d]\n",
c_node->property.prop_id);
goto err_unlock;
}

switch (cmd_work->ctrl) {
case IPP_CTRL_PLAY:
Expand Down

0 comments on commit 0ca824c

Please sign in to comment.