Skip to content

Commit

Permalink
iio: dac: ad5504: Don't set error code to voltage_uv
Browse files Browse the repository at this point in the history
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Axel Lin authored and Jonathan Cameron committed Dec 27, 2012
1 parent 7e2dcc6 commit 0ce2fda
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/iio/dac/ad5504.c
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,11 @@ static int __devinit ad5504_probe(struct spi_device *spi)
if (ret)
goto error_put_reg;

voltage_uv = regulator_get_voltage(reg);
ret = regulator_get_voltage(reg);
if (ret < 0)
goto error_disable_reg;

voltage_uv = ret;
}

spi_set_drvdata(spi, indio_dev);
Expand Down

0 comments on commit 0ce2fda

Please sign in to comment.