Skip to content

Commit

Permalink
staging: ti dspbridge: deh: free dummy page immediately
Browse files Browse the repository at this point in the history
There's no need to keep it around. DSP should stop trying to access
system memory.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Felipe Contreras authored and Greg Kroah-Hartman committed Jul 8, 2010
1 parent 599ede1 commit 0d8631d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/staging/tidspbridge/core/ue_deh.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@
#include <dspbridge/io_sm.h>


static void *dummy_va_addr;

int bridge_deh_create(struct deh_mgr **ret_deh_mgr,
struct dev_object *hdev_obj)
{
Expand Down Expand Up @@ -154,6 +152,7 @@ void bridge_deh_notify(struct deh_mgr *deh_mgr, u32 ulEventMask, u32 dwErrInfo)
.element_size = HW_ELEM_SIZE16BIT,
.mixed_size = HW_MMU_CPUES,
};
void *dummy_va_addr;

if (!deh_mgr)
return;
Expand Down Expand Up @@ -214,6 +213,9 @@ void bridge_deh_notify(struct deh_mgr *deh_mgr, u32 ulEventMask, u32 dwErrInfo)
HW_MMU_TRANSLATION_FAULT);
dump_dsp_stack(dev_context);
dsp_clk_disable(DSP_CLK_GPT8);

hw_mmu_disable(resources->dw_dmmu_base);
free_page((unsigned long)dummy_va_addr);
break;
#ifdef CONFIG_BRIDGE_NTFY_PWRERR
case DSP_PWRERROR:
Expand Down Expand Up @@ -276,6 +278,4 @@ int bridge_deh_get_info(struct deh_mgr *deh_mgr,

void bridge_deh_release_dummy_mem(void)
{
free_page((unsigned long)dummy_va_addr);
dummy_va_addr = NULL;
}

0 comments on commit 0d8631d

Please sign in to comment.