Skip to content

Commit

Permalink
drbd: drbd_may_do_local_read(): Use bool/true/false
Browse files Browse the repository at this point in the history
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
  • Loading branch information
Andreas Gruenbacher authored and Philipp Reisner committed Nov 8, 2012
1 parent 1097e9a commit 0da34df
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions drivers/block/drbd/drbd_req.c
Original file line number Diff line number Diff line change
Expand Up @@ -671,25 +671,24 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what,
* since size may be bigger than BM_BLOCK_SIZE,
* we may need to check several bits.
*/
static int drbd_may_do_local_read(struct drbd_conf *mdev, sector_t sector, int size)
static bool drbd_may_do_local_read(struct drbd_conf *mdev, sector_t sector, int size)
{
unsigned long sbnr, ebnr;
sector_t esector, nr_sectors;

if (mdev->state.disk == D_UP_TO_DATE)
return 1;
return true;
if (mdev->state.disk != D_INCONSISTENT)
return 0;
return false;
esector = sector + (size >> 9) - 1;

nr_sectors = drbd_get_capacity(mdev->this_bdev);
D_ASSERT(sector < nr_sectors);
D_ASSERT(esector < nr_sectors);

sbnr = BM_SECT_TO_BIT(sector);
ebnr = BM_SECT_TO_BIT(esector);

return 0 == drbd_bm_count_bits(mdev, sbnr, ebnr);
return drbd_bm_count_bits(mdev, sbnr, ebnr) == 0;
}

/*
Expand Down

0 comments on commit 0da34df

Please sign in to comment.