Skip to content

Commit

Permalink
[PATCH] kill old EH constants
Browse files Browse the repository at this point in the history
Fix up two drivers that incorrectly were using the old return values for
their new-style EH methods and kill off scsi_obsolete.h that defined the
constants.  The initio driver has all these constansts defined locally
and uses them internally, I'll fix that up some time later.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Unknown authored and James Bottomley committed Apr 17, 2005
1 parent 84011ae commit 0db7157
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 115 deletions.
6 changes: 0 additions & 6 deletions drivers/scsi/scsi.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ struct scatterlist;
#define scsi_to_pci_dma_dir(scsi_dir) ((int)(scsi_dir))
#define scsi_to_sbus_dma_dir(scsi_dir) ((int)(scsi_dir))

/*
* This is the crap from the old error handling code. We have it in a special
* place so that we can more easily delete it later on.
*/
#include "scsi_obsolete.h"

/* obsolete typedef junk. */
#include "scsi_typedefs.h"

Expand Down
106 changes: 0 additions & 106 deletions drivers/scsi/scsi_obsolete.h

This file was deleted.

4 changes: 2 additions & 2 deletions drivers/scsi/ultrastor.c
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ static int ultrastor_abort(Scsi_Cmnd *SCpnt)
config.mscp[mscp_index].SCint, SCpnt);
#endif
if (config.mscp[mscp_index].SCint == 0)
return SCSI_ABORT_NOT_RUNNING;
return FAILURE;

if (config.mscp[mscp_index].SCint != SCpnt) panic("Bad abort");
config.mscp[mscp_index].SCint = NULL;
Expand Down Expand Up @@ -1020,7 +1020,7 @@ static int ultrastor_host_reset(Scsi_Cmnd * SCpnt)
#endif

spin_unlock_irqrestore(host->host_lock, flags);
return SCSI_RESET_SUCCESS;
return SUCCESS;

}

Expand Down
2 changes: 1 addition & 1 deletion drivers/usb/image/microtek.c
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ static int mts_scsi_abort (Scsi_Cmnd *srb)

mts_urb_abort(desc);

return SCSI_ABORT_PENDING;
return FAILURE;
}

static int mts_scsi_host_reset (Scsi_Cmnd *srb)
Expand Down

0 comments on commit 0db7157

Please sign in to comment.