Skip to content

Commit

Permalink
[PATCH] nfsd4: ERR_GRACE should bump seqid on lock
Browse files Browse the repository at this point in the history
A GRACE or NOGRACE response to a lock request should also bump the sequence
id.  So we delay the handling of grace period errors till after we've found
the relevant owner.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
NeilBrown authored and Linus Torvalds committed Jul 8, 2005
1 parent b648330 commit 0dd395d
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -2706,11 +2706,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_lock
(long long) lock->lk_offset,
(long long) lock->lk_length);

if (nfs4_in_grace() && !lock->lk_reclaim)
return nfserr_grace;
if (!nfs4_in_grace() && lock->lk_reclaim)
return nfserr_no_grace;

if (check_lock_length(lock->lk_offset, lock->lk_length))
return nfserr_inval;

Expand Down Expand Up @@ -2785,6 +2780,13 @@ nfsd4_lock(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_lock
goto out;
}

status = nfserr_grace;
if (nfs4_in_grace() && !lock->lk_reclaim)
goto out;
status = nfserr_no_grace;
if (!nfs4_in_grace() && lock->lk_reclaim)
goto out;

locks_init_lock(&file_lock);
switch (lock->lk_type) {
case NFS4_READ_LT:
Expand Down

0 comments on commit 0dd395d

Please sign in to comment.