Skip to content

Commit

Permalink
hso: Fix for 5 sec timeouts with v2.x firmware
Browse files Browse the repository at this point in the history
Don't send flow control settings to any port other than the modem port.
Older firmware ignored this request but did sent a reply. Newer firmware just
ignores it without reply and causes a 5 second timeout every time a port
(except for the modem port) is opened or if tiocm settings are changed.

Signed-off-by: Jan Dumon <j.dumon@option.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jan Dumon authored and David S. Miller committed Jan 7, 2010
1 parent 68a351c commit 0e0367e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/net/usb/hso.c
Original file line number Diff line number Diff line change
Expand Up @@ -1723,6 +1723,10 @@ static int hso_serial_tiocmset(struct tty_struct *tty, struct file *file,
D1("no tty structures");
return -EINVAL;
}

if ((serial->parent->port_spec & HSO_PORT_MASK) != HSO_PORT_MODEM)
return -EINVAL;

if_num = serial->parent->interface->altsetting->desc.bInterfaceNumber;

spin_lock_irqsave(&serial->serial_lock, flags);
Expand Down

0 comments on commit 0e0367e

Please sign in to comment.