Skip to content

Commit

Permalink
ACPICA: Debugger: reduce old external path format
Browse files Browse the repository at this point in the history
ACPICA commit 75c0da9e796bdf9bdd46d75f028a3e1779903214

In the error logs and debugger outputs, use new external path format that
does not contain a trailing underscore.

This patch takes care of acpi_ns_get_external_pathname() invocations, chaning
them into acpi_ns_get_normalized_pathname(TRUE) where possible. Along with some
error log fixes, the following debugger commands are fixed: resources,
handlers, paths. Lv Zheng.

Link: https://github.com/acpica/acpica/commit/75c0da9e
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Lv Zheng authored and Rafael J. Wysocki committed Jan 1, 2016
1 parent ac9b64a commit 0e166e4
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/dbcmds.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ acpi_db_device_resources(acpi_handle obj_handle,
acpi_status status;

node = ACPI_CAST_PTR(struct acpi_namespace_node, obj_handle);
parent_path = acpi_ns_get_external_pathname(node);
parent_path = acpi_ns_get_normalized_pathname(node, TRUE);
if (!parent_path) {
return (AE_NO_MEMORY);
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/dbdisply.c
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,7 @@ acpi_db_display_non_root_handlers(acpi_handle obj_handle,
return (AE_OK);
}

pathname = acpi_ns_get_external_pathname(node);
pathname = acpi_ns_get_normalized_pathname(node, TRUE);
if (!pathname) {
return (AE_OK);
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/dbnames.c
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ acpi_db_walk_for_predefined_names(acpi_handle obj_handle,
return (AE_OK);
}

pathname = acpi_ns_get_external_pathname(node);
pathname = acpi_ns_get_normalized_pathname(node, TRUE);
if (!pathname) {
return (AE_OK);
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/dbtest.c
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ acpi_db_evaluate_one_predefined_name(acpi_handle obj_handle,
return (AE_OK);
}

pathname = acpi_ns_get_external_pathname(node);
pathname = acpi_ns_get_normalized_pathname(node, TRUE);
if (!pathname) {
return (AE_OK);
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/nsdump.c
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ acpi_ns_dump_one_object_path(acpi_handle obj_handle,
return (AE_OK);
}

pathname = acpi_ns_get_external_pathname(node);
pathname = acpi_ns_get_normalized_pathname(node, TRUE);

path_indent = 1;
if (level <= max_level) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/nseval.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ acpi_status acpi_ns_evaluate(struct acpi_evaluate_info *info)

/* Get the full pathname to the object, for use in warning messages */

info->full_pathname = acpi_ns_get_external_pathname(info->node);
info->full_pathname = acpi_ns_get_normalized_pathname(info->node, TRUE);
if (!info->full_pathname) {
return_ACPI_STATUS(AE_NO_MEMORY);
}
Expand Down
3 changes: 2 additions & 1 deletion drivers/acpi/acpica/nsinit.c
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,8 @@ acpi_ns_init_one_device(acpi_handle obj_handle,

/* Ignore error and move on to next device */

char *scope_name = acpi_ns_get_external_pathname(device_node);
char *scope_name =
acpi_ns_get_normalized_pathname(device_node, TRUE);

ACPI_EXCEPTION((AE_INFO, status, "during %s._INI execution",
scope_name));
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/nssearch.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ acpi_ns_search_one_scope(u32 target_name,
if (ACPI_LV_NAMES & acpi_dbg_level) {
char *scope_name;

scope_name = acpi_ns_get_external_pathname(parent_node);
scope_name = acpi_ns_get_normalized_pathname(parent_node, TRUE);
if (scope_name) {
ACPI_DEBUG_PRINT((ACPI_DB_NAMES,
"Searching %s (%p) For [%4.4s] (%s)\n",
Expand Down
5 changes: 3 additions & 2 deletions drivers/acpi/acpica/utaddress.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,9 @@ acpi_ut_check_address_range(acpi_adr_space_type space_id,
overlap_count++;
if (warn) { /* Optional warning message */
pathname =
acpi_ns_get_external_pathname(range_info->
region_node);
acpi_ns_get_normalized_pathname(range_info->
region_node,
TRUE);

ACPI_WARNING((AE_INFO,
"%s range 0x%8.8X%8.8X-0x%8.8X%8.8X conflicts with OpRegion 0x%8.8X%8.8X-0x%8.8X%8.8X (%s)",
Expand Down

0 comments on commit 0e166e4

Please sign in to comment.