Skip to content

Commit

Permalink
OMAP3+: VP: move SoC-specific sys clock rate retreival late init
Browse files Browse the repository at this point in the history
Add sys clock name and rate to struct voltage domain.  SoC specific
voltagedomain init code initializes sys clock name.  After clock
framework is initialized, voltage late init will then use use the
sys_clk rate to calculate the various timing that depend on that rate.

Signed-off-by: Kevin Hilman <khilman@ti.com>
  • Loading branch information
Kevin Hilman committed Sep 15, 2011
1 parent 0ec3041 commit 0e2f3d9
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 30 deletions.
47 changes: 17 additions & 30 deletions arch/arm/mach-omap2/voltage.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@

#include <linux/delay.h>
#include <linux/io.h>
#include <linux/clk.h>
#include <linux/err.h>
#include <linux/debugfs.h>
#include <linux/slab.h>
#include <linux/clk.h>

#include <plat/common.h>

Expand All @@ -45,36 +45,12 @@ static LIST_HEAD(voltdm_list);

static int __init _config_common_vdd_data(struct voltagedomain *voltdm)
{
char *sys_ck_name;
struct clk *sys_ck;
u32 sys_clk_speed, timeout_val, waittime;
struct omap_vdd_info *vdd = voltdm->vdd;
u32 sys_clk_rate, timeout_val, waittime;

/*
* XXX Clockfw should handle this, or this should be in a
* struct record
*/
if (cpu_is_omap24xx() || cpu_is_omap34xx())
sys_ck_name = "sys_ck";
else if (cpu_is_omap44xx())
sys_ck_name = "sys_clkin_ck";
else
return -EINVAL;

/*
* Sys clk rate is require to calculate vp timeout value and
* smpswaittimemin and smpswaittimemax.
*/
sys_ck = clk_get(NULL, sys_ck_name);
if (IS_ERR(sys_ck)) {
pr_warning("%s: Could not get the sys clk to calculate"
"various vdd_%s params\n", __func__, voltdm->name);
return -EINVAL;
}
sys_clk_speed = clk_get_rate(sys_ck);
clk_put(sys_ck);
/* Divide to avoid overflow */
sys_clk_speed /= 1000;
sys_clk_rate = voltdm->sys_clk.rate / 1000;
WARN_ON(!sys_clk_rate);

/* Generic voltage parameters */
vdd->volt_scale = omap_vp_forceupdate_scale;
Expand All @@ -84,13 +60,13 @@ static int __init _config_common_vdd_data(struct voltagedomain *voltdm)
(voltdm->pmic->vp_erroroffset <<
__ffs(voltdm->vp->common->vpconfig_erroroffset_mask));

timeout_val = (sys_clk_speed * voltdm->pmic->vp_timeout_us) / 1000;
timeout_val = (sys_clk_rate * voltdm->pmic->vp_timeout_us) / 1000;
vdd->vp_rt_data.vlimitto_timeout = timeout_val;
vdd->vp_rt_data.vlimitto_vddmin = voltdm->pmic->vp_vddmin;
vdd->vp_rt_data.vlimitto_vddmax = voltdm->pmic->vp_vddmax;

waittime = ((voltdm->pmic->step_size / voltdm->pmic->slew_rate) *
sys_clk_speed) / 1000;
sys_clk_rate) / 1000;
vdd->vp_rt_data.vstepmin_smpswaittimemin = waittime;
vdd->vp_rt_data.vstepmax_smpswaittimemax = waittime;
vdd->vp_rt_data.vstepmin_stepmin = voltdm->pmic->vp_vstepmin;
Expand Down Expand Up @@ -346,9 +322,20 @@ int __init omap_voltage_late_init(void)
}

list_for_each_entry(voltdm, &voltdm_list, node) {
struct clk *sys_ck;

if (!voltdm->scalable)
continue;

sys_ck = clk_get(NULL, voltdm->sys_clk.name);
if (IS_ERR(sys_ck)) {
pr_warning("%s: Could not get sys clk.\n", __func__);
return -EINVAL;
}
voltdm->sys_clk.rate = clk_get_rate(sys_ck);
WARN_ON(!voltdm->sys_clk.rate);
clk_put(sys_ck);

if (voltdm->vc) {
voltdm->vdd->volt_scale = omap_vc_bypass_scale;
omap_vc_init_channel(voltdm);
Expand Down
6 changes: 6 additions & 0 deletions arch/arm/mach-omap2/voltage.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ struct omap_vfsm_instance {
* @read: read a VC/VP register
* @write: write a VC/VP register
* @read: read-modify-write a VC/VP register
* @sys_clk: system clock name/frequency, used for various timing calculations
* @vdd: to be removed
*/
struct voltagedomain {
Expand All @@ -76,6 +77,11 @@ struct voltagedomain {
void (*write) (u32 val, u8 offset);
u32 (*rmw)(u32 mask, u32 bits, u8 offset);

union {
const char *name;
u32 rate;
} sys_clk;

struct omap_vdd_info *vdd;
};

Expand Down
8 changes: 8 additions & 0 deletions arch/arm/mach-omap2/voltagedomains3xxx_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,13 @@ static struct voltagedomain *voltagedomains_omap3[] __initdata = {
NULL,
};

static const char *sys_clk_name __initdata = "sys_ck";

void __init omap3xxx_voltagedomains_init(void)
{
struct voltagedomain *voltdm;
int i;

/*
* XXX Will depend on the process, validation, and binning
* for the currently-running IC
Expand All @@ -94,5 +99,8 @@ void __init omap3xxx_voltagedomains_init(void)
omap3_vdd2_info.volt_data = omap34xx_vddcore_volt_data;
}

for (i = 0; voltdm = voltagedomains_omap3[i], voltdm; i++)
voltdm->sys_clk.name = sys_clk_name;

voltdm_init(voltagedomains_omap3);
};
8 changes: 8 additions & 0 deletions arch/arm/mach-omap2/voltagedomains44xx_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,13 @@ static struct voltagedomain *voltagedomains_omap4[] __initdata = {
NULL,
};

static const char *sys_clk_name __initdata = "sys_clkin_ck";

void __init omap44xx_voltagedomains_init(void)
{
struct voltagedomain *voltdm;
int i;

/*
* XXX Will depend on the process, validation, and binning
* for the currently-running IC
Expand All @@ -108,5 +113,8 @@ void __init omap44xx_voltagedomains_init(void)
omap4_vdd_iva_info.volt_data = omap44xx_vdd_iva_volt_data;
omap4_vdd_core_info.volt_data = omap44xx_vdd_core_volt_data;

for (i = 0; voltdm = voltagedomains_omap4[i], voltdm; i++)
voltdm->sys_clk.name = sys_clk_name;

voltdm_init(voltagedomains_omap4);
};

0 comments on commit 0e2f3d9

Please sign in to comment.