Skip to content

Commit

Permalink
PCI: pciehp: remove hp_slot field
Browse files Browse the repository at this point in the history
The hp_slot field is to identify the slot under the same
controller. But, since PCIe downstream port has only one slot at most,
it is meaningless and we don't need it.

Acked-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Kenji Kaneshige authored and Jesse Barnes committed Sep 17, 2009
1 parent d689f7e commit 0e36315
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 12 deletions.
1 change: 0 additions & 1 deletion drivers/pci/hotplug/pciehp.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ do { \
#define SLOT_NAME_SIZE 10
struct slot {
u8 state;
u8 hp_slot;
u32 number;
struct controller *ctrl;
struct hpc_ops *hpc_ops;
Expand Down
4 changes: 2 additions & 2 deletions drivers/pci/hotplug/pciehp_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ static int init_slot(struct controller *ctrl)
snprintf(name, SLOT_NAME_SIZE, "%u", slot->number);

ctrl_dbg(ctrl, "Registering domain:bus:dev=%04x:%02x:00 "
"hp_slot=%x sun=%x slot_device_offset=%x\n",
"sun=%x slot_device_offset=%x\n",
pci_domain_nr(ctrl->pci_dev->subordinate),
ctrl->pci_dev->subordinate->number,
slot->hp_slot, slot->number, ctrl->slot_device_offset);
slot->number, ctrl->slot_device_offset);
retval = pci_hp_register(hotplug,
ctrl->pci_dev->subordinate, 0, name);
if (retval) {
Expand Down
6 changes: 2 additions & 4 deletions drivers/pci/hotplug/pciehp_ctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ static int board_added(struct slot *p_slot)
struct controller *ctrl = p_slot->ctrl;
struct pci_bus *parent = ctrl->pci_dev->subordinate;

ctrl_dbg(ctrl, "%s: slot device, slot offset, hp slot = 0, %d, %d\n",
__func__, ctrl->slot_device_offset, p_slot->hp_slot);
ctrl_dbg(ctrl, "%s: slot device, slot offset = 0, %d\n",
__func__, ctrl->slot_device_offset);

if (POWER_CTRL(ctrl)) {
/* Power on slot */
Expand Down Expand Up @@ -268,8 +268,6 @@ static int remove_board(struct slot *p_slot)
if (retval)
return retval;

ctrl_dbg(ctrl, "%s: hp_slot = %d\n", __func__, p_slot->hp_slot);

if (POWER_CTRL(ctrl)) {
/* power off slot */
retval = p_slot->hpc_ops->power_off_slot(p_slot);
Expand Down
5 changes: 0 additions & 5 deletions drivers/pci/hotplug/pciehp_hpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,6 @@ static int hpc_power_on_slot(struct slot * slot)
u16 slot_status;
int retval = 0;

ctrl_dbg(ctrl, "%s: slot->hp_slot %x\n", __func__, slot->hp_slot);

/* Clear sticky power-fault bit from previous power failures */
retval = pciehp_readw(ctrl, PCI_EXP_SLTSTA, &slot_status);
if (retval) {
Expand Down Expand Up @@ -578,8 +576,6 @@ static int hpc_power_off_slot(struct slot * slot)
int retval = 0;
int changed;

ctrl_dbg(ctrl, "%s: slot->hp_slot %x\n", __func__, slot->hp_slot);

/*
* Set Bad DLLP Mask bit in Correctable Error Mask
* Register. This is the workaround against Bad DLLP error
Expand Down Expand Up @@ -928,7 +924,6 @@ static int pcie_init_slot(struct controller *ctrl)
if (!slot)
return -ENOMEM;

slot->hp_slot = 0;
slot->ctrl = ctrl;
slot->hpc_ops = ctrl->hpc_ops;
slot->number = ctrl->first_slot;
Expand Down

0 comments on commit 0e36315

Please sign in to comment.