Skip to content

Commit

Permalink
igbvf: force link checking when mailbox timeout has occurred
Browse files Browse the repository at this point in the history
This change forces the link down when a mailbox timeout has occurred.
Previously it was possible for a mailbox timeout to occur but for the
interface to stay up.  The problem with this was that it became possible
for an interface to stay up and miss multiple requests resulting in a
possible issue since the interface will be running in an unknown state.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Alexander Duyck authored and Jeff Kirsher committed Dec 25, 2010
1 parent 1380046 commit 0e512bf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/igbvf/vf.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,8 @@ static s32 e1000_check_for_link_vf(struct e1000_hw *hw)
* or a virtual function reset
*/

/* If we were hit with a reset drop the link */
if (!mbx->ops.check_for_rst(hw))
/* If we were hit with a reset or timeout drop the link */
if (!mbx->ops.check_for_rst(hw) || !mbx->timeout)
mac->get_link_status = true;

if (!mac->get_link_status)
Expand Down

0 comments on commit 0e512bf

Please sign in to comment.