Skip to content

Commit

Permalink
arch/arm/mach-omap2/dma.c: Convert IS_ERR result to PTR_ERR
Browse files Browse the repository at this point in the history
This code elsewhere returns a negative constant to an indicate an error,
while IS_ERR returns the result of a >= operation.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
@@

 if (...) { ...
- return IS_ERR(x);
+ return PTR_ERR(x);
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
  • Loading branch information
Julia Lawall authored and Tony Lindgren committed Jan 28, 2011
1 parent afb7d70 commit 0e6d8ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
if (IS_ERR(od)) {
pr_err("%s: Cant build omap_device for %s:%s.\n",
__func__, name, oh->name);
return IS_ERR(od);
return PTR_ERR(od);
}

mem = platform_get_resource(&od->pdev, IORESOURCE_MEM, 0);
Expand Down

0 comments on commit 0e6d8ca

Please sign in to comment.