Skip to content

Commit

Permalink
uml: turn build warnings into comments
Browse files Browse the repository at this point in the history
These haven't been fixed for ages.  Just make comments out of them.

arch/um/kernel/skas/process.c:181:2: warning: #warning Need to look up
+userspace_pid by cpu
arch/um/kernel/skas/process.c:187:2: warning: #warning Need to look up
+userspace_pid by cpu
arch/um/kernel/skas/process.c:194:2: warning: #warning need to loop over
+userspace_pids in kill_off_processes_skas

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Miklos Szeredi authored and Linus Torvalds committed May 9, 2007
1 parent cb0c78c commit 0e7d18b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
9 changes: 6 additions & 3 deletions arch/um/kernel/skas/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,20 +178,23 @@ int start_uml_skas(void)

int external_pid_skas(struct task_struct *task)
{
#warning Need to look up userspace_pid by cpu
/* FIXME: Need to look up userspace_pid by cpu */
return(userspace_pid[0]);
}

int thread_pid_skas(struct task_struct *task)
{
#warning Need to look up userspace_pid by cpu
/* FIXME: Need to look up userspace_pid by cpu */
return(userspace_pid[0]);
}

void kill_off_processes_skas(void)
{
if(proc_mm)
#warning need to loop over userspace_pids in kill_off_processes_skas
/*
* FIXME: need to loop over userspace_pids in
* kill_off_processes_skas
*/
os_kill_ptraced_process(userspace_pid[0], 1);
else {
struct task_struct *p;
Expand Down
2 changes: 1 addition & 1 deletion arch/um/os-Linux/skas/mem.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ static inline long do_syscall_stub(struct mm_id * mm_idp, void **addr)
int err, pid = mm_idp->u.pid;

if(proc_mm)
#warning Need to look up userspace_pid by cpu
/* FIXME: Need to look up userspace_pid by cpu */
pid = userspace_pid[0];

multi_count++;
Expand Down
2 changes: 1 addition & 1 deletion arch/um/os-Linux/skas/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ void switch_mm_skas(struct mm_id *mm_idp)
{
int err;

#warning need cpu pid in switch_mm_skas
/* FIXME: need cpu pid in switch_mm_skas */
if(proc_mm){
err = ptrace(PTRACE_SWITCH_MM, userspace_pid[0], 0,
mm_idp->u.mm_fd);
Expand Down

0 comments on commit 0e7d18b

Please sign in to comment.