Skip to content

Commit

Permalink
netdev: bfin_mac: check for mii_bus platform data
Browse files Browse the repository at this point in the history
If the platform data for the mii_bus is missing, gracefully error out
rather than deference NULL pointers.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sonic Zhang authored and David S. Miller committed May 18, 2010
1 parent 2bfa0f0 commit 0e995cd
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/net/bfin_mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1466,6 +1466,11 @@ static int __devinit bfin_mac_probe(struct platform_device *pdev)
}
pd = pdev->dev.platform_data;
lp->mii_bus = platform_get_drvdata(pd);
if (!lp->mii_bus) {
dev_err(&pdev->dev, "Cannot get mii_bus!\n");
rc = -ENODEV;
goto out_err_mii_bus_probe;
}
lp->mii_bus->priv = ndev;

rc = mii_probe(ndev);
Expand Down Expand Up @@ -1511,6 +1516,7 @@ static int __devinit bfin_mac_probe(struct platform_device *pdev)
out_err_mii_probe:
mdiobus_unregister(lp->mii_bus);
mdiobus_free(lp->mii_bus);
out_err_mii_bus_probe:
peripheral_free_list(pin_req);
out_err_probe_mac:
platform_set_drvdata(pdev, NULL);
Expand Down

0 comments on commit 0e995cd

Please sign in to comment.