Skip to content

Commit

Permalink
KVM: cleanup memslot_id function
Browse files Browse the repository at this point in the history
We can get memslot id from memslot->id directly

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Xiao Guangrong authored and Avi Kivity committed May 11, 2011
1 parent 9f381a6 commit 0ee8dcb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 18 deletions.
6 changes: 5 additions & 1 deletion include/linux/kvm_host.h
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ pfn_t gfn_to_pfn_prot(struct kvm *kvm, gfn_t gfn, bool write_fault,
bool *writable);
pfn_t gfn_to_pfn_memslot(struct kvm *kvm,
struct kvm_memory_slot *slot, gfn_t gfn);
int memslot_id(struct kvm *kvm, gfn_t gfn);
void kvm_release_pfn_dirty(pfn_t);
void kvm_release_pfn_clean(pfn_t pfn);
void kvm_set_pfn_dirty(pfn_t pfn);
Expand Down Expand Up @@ -597,6 +596,11 @@ static inline void kvm_guest_exit(void)
current->flags &= ~PF_VCPU;
}

static inline int memslot_id(struct kvm *kvm, gfn_t gfn)
{
return gfn_to_memslot(kvm, gfn)->id;
}

static inline unsigned long gfn_to_hva_memslot(struct kvm_memory_slot *slot,
gfn_t gfn)
{
Expand Down
17 changes: 0 additions & 17 deletions virt/kvm/kvm_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -996,23 +996,6 @@ unsigned long kvm_host_page_size(struct kvm *kvm, gfn_t gfn)
return size;
}

int memslot_id(struct kvm *kvm, gfn_t gfn)
{
int i;
struct kvm_memslots *slots = kvm_memslots(kvm);
struct kvm_memory_slot *memslot = NULL;

for (i = 0; i < slots->nmemslots; ++i) {
memslot = &slots->memslots[i];

if (gfn >= memslot->base_gfn
&& gfn < memslot->base_gfn + memslot->npages)
break;
}

return memslot - slots->memslots;
}

static unsigned long gfn_to_hva_many(struct kvm_memory_slot *slot, gfn_t gfn,
gfn_t *nr_pages)
{
Expand Down

0 comments on commit 0ee8dcb

Please sign in to comment.