Skip to content

Commit

Permalink
[PATCH] Voyager: tty locking
Browse files Browse the repository at this point in the history
Voyager fiddles with current->signal.tty without locking.  It turns out
that the code in question has already cleared current->signal.tty correctly
because daemonize() does the right thing already.

The signal handling also appears to be incorrect as it does an unprotected
sigfillset that also appears unneccessary.  As I don't have a bowtie and am
therefore not a qualified voyager maintainer I leave that to James.

Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Alan Cox authored and Linus Torvalds committed Sep 26, 2006
1 parent a3bc0db commit 0f0f1b4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/i386/mach-voyager/voyager_thread.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ thread(void *unused)
init_timer(&wakeup_timer);

sigfillset(&current->blocked);
current->signal->tty = NULL;

printk(KERN_NOTICE "Voyager starting monitor thread\n");

Expand Down

0 comments on commit 0f0f1b4

Please sign in to comment.