Skip to content

Commit

Permalink
video: xilinxfb: Fix OF probing on little-endian systems
Browse files Browse the repository at this point in the history
DTB is always big-endian that's why it is necessary
to properly convert value (*p).
It is automatically done in of_property_read_u32().

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Michal Simek authored and Tomi Valkeinen committed Jun 26, 2013
1 parent ffa3fd2 commit 0f5e17c
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/video/xilinxfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,7 @@ static int xilinxfb_release(struct device *dev)
static int xilinxfb_of_probe(struct platform_device *op)
{
const u32 *prop;
u32 *p;
u32 tft_access;
u32 tft_access = 0;
struct xilinxfb_platform_data pdata;
struct resource res;
int size, rc;
Expand All @@ -427,8 +426,8 @@ static int xilinxfb_of_probe(struct platform_device *op)
* To check whether the core is connected directly to DCR or PLB
* interface and initialize the tft_access accordingly.
*/
p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL);
tft_access = p ? *p : 0;
of_property_read_u32(op->dev.of_node, "xlnx,dcr-splb-slave-if",
&tft_access);

/*
* Fill the resource structure if its direct PLB interface
Expand Down

0 comments on commit 0f5e17c

Please sign in to comment.