Skip to content

Commit

Permalink
ACPICA: Enhance ACPI warning for memory/IO address conflicts.
Browse files Browse the repository at this point in the history
This change improves the warning message when a system address
conflicts with an existing operation region. It now emits the region
address range in addition to the input (system) address range.

Reported-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Bob Moore authored and Rafael J. Wysocki committed Jan 8, 2014
1 parent 87beb7e commit 0f607cb
Showing 1 changed file with 13 additions and 6 deletions.
19 changes: 13 additions & 6 deletions drivers/acpi/acpica/utaddress.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,11 @@ acpi_ut_check_address_range(acpi_adr_space_type space_id,

while (range_info) {
/*
* Check if the requested Address/Length overlaps this address_range.
* Four cases to consider:
* Check if the requested address/length overlaps this
* address range. There are four cases to consider:
*
* 1) Input address/length is contained completely in the address range
* 1) Input address/length is contained completely in the
* address range
* 2) Input address/length overlaps range at the range start
* 3) Input address/length overlaps range at the range end
* 4) Input address/length completely encompasses the range
Expand All @@ -244,11 +245,17 @@ acpi_ut_check_address_range(acpi_adr_space_type space_id,
region_node);

ACPI_WARNING((AE_INFO,
"0x%p-0x%p %s conflicts with Region %s %d",
"%s range 0x%p-0x%p conflicts with OpRegion 0x%p-0x%p (%s)",
acpi_ut_get_region_name(space_id),
ACPI_CAST_PTR(void, address),
ACPI_CAST_PTR(void, end_address),
acpi_ut_get_region_name(space_id),
pathname, overlap_count));
ACPI_CAST_PTR(void,
range_info->
start_address),
ACPI_CAST_PTR(void,
range_info->
end_address),
pathname));
ACPI_FREE(pathname);
}
}
Expand Down

0 comments on commit 0f607cb

Please sign in to comment.