Skip to content

Commit

Permalink
[POWERPC] celleb: Fix PCI config space accesses to subordinate buses
Browse files Browse the repository at this point in the history
Checking whether bus->self is NULL is not enough to know "bus" is the
primary bus.

Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Ishizaki Kou authored and Paul Mackerras committed May 10, 2007
1 parent d1af5b4 commit 0f6e74a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions arch/powerpc/platforms/celleb/scc_epci.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,13 @@ static int celleb_epci_check_abort(struct pci_controller *hose,
}

static volatile void __iomem *celleb_epci_make_config_addr(
struct pci_bus *bus,
struct pci_controller *hose,
unsigned int devfn, int where)
{
volatile void __iomem *addr;
struct pci_bus *bus = hose->bus;

if (bus->self)
if (bus != hose->bus)
addr = celleb_epci_get_epci_cfg(hose) +
(((bus->number & 0xff) << 16)
| ((devfn & 0xff) << 8)
Expand Down Expand Up @@ -193,7 +193,7 @@ static int celleb_epci_read_config(struct pci_bus *bus,
} else {

clear_and_disable_master_abort_interrupt(hose);
addr = celleb_epci_make_config_addr(hose, devfn, where);
addr = celleb_epci_make_config_addr(bus, hose, devfn, where);

switch (size) {
case 1:
Expand Down Expand Up @@ -257,7 +257,7 @@ static int celleb_epci_write_config(struct pci_bus *bus,
} else {

clear_and_disable_master_abort_interrupt(hose);
addr = celleb_epci_make_config_addr(hose, devfn, where);
addr = celleb_epci_make_config_addr(bus, hose, devfn, where);

switch (size) {
case 1:
Expand Down

0 comments on commit 0f6e74a

Please sign in to comment.