Skip to content

Commit

Permalink
[PATCH] mm: make __put_page internal
Browse files Browse the repository at this point in the history
Remove __put_page from outside the core mm/.  It is dangerous because it does
not handle compound pages nicely, and misses 1->0 transitions.  If a user
later appears that really needs the extra speed we can reevaluate.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Nick Piggin authored and Linus Torvalds committed Mar 22, 2006
1 parent 4fa4f53 commit 0f8053a
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 1 deletion.
1 change: 0 additions & 1 deletion include/linux/mm.h
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ static inline int get_page_unless_zero(struct page *page)
}

#define set_page_count(p,v) atomic_set(&(p)->_count, (v))
#define __put_page(p) atomic_dec(&(p)->_count)

extern void FASTCALL(__page_cache_release(struct page *));

Expand Down
2 changes: 2 additions & 0 deletions mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
#include <linux/security.h>
#include <linux/syscalls.h>
#include "filemap.h"
#include "internal.h"

/*
* FIXME: remove all knowledge of the buffer layer from the core VM
*/
Expand Down
11 changes: 11 additions & 0 deletions mm/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
* as published by the Free Software Foundation; either version
* 2 of the License, or (at your option) any later version.
*/
#ifndef __MM_INTERNAL_H
#define __MM_INTERNAL_H

#include <linux/mm.h>

static inline void set_page_refs(struct page *page, int order)
{
Expand All @@ -26,5 +30,12 @@ static inline void set_page_refs(struct page *page, int order)
#endif /* CONFIG_MMU */
}

static inline void __put_page(struct page *page)
{
atomic_dec(&page->_count);
}

extern void fastcall __init __free_pages_bootmem(struct page *page,
unsigned int order);

#endif
2 changes: 2 additions & 0 deletions mm/vmscan.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@

#include <linux/swapops.h>

#include "internal.h"

/* possible outcome of pageout() */
typedef enum {
/* failed to write page out, page is locked */
Expand Down

0 comments on commit 0f8053a

Please sign in to comment.